From: Max Carrara <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common 1/2] certificate: add subroutine that checks if cert and key match
Date: Tue, 28 Feb 2023 17:36:31 +0100 [thread overview]
Message-ID: <20230228163634.299137-2-m.carrara@proxmox.com> (raw)
In-Reply-To: <20230228163634.299137-1-m.carrara@proxmox.com>
This is done here in order to allow other packages to make use of
this subroutine.
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
---
src/PVE/Certificate.pm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm
index 31a7722..5ec1c6b 100644
--- a/src/PVE/Certificate.pm
+++ b/src/PVE/Certificate.pm
@@ -228,6 +228,32 @@ sub get_certificate_fingerprint {
return $fp;
}
+sub certificate_matches_key {
+ my ($cert_path, $key_path) = @_;
+
+ die "No certificate path given!\n" if !$cert_path;
+ die "No certificate key path given!\n" if !$key_path;
+
+ die "Certificate at '$cert_path' does not exist!\n" if ! -e $cert_path;
+ die "Certificate key '$key_path' does not exist!\n" if ! -e $key_path;
+
+ my $ctx = Net::SSLeay::CTX_new()
+ or $ssl_die->(
+ "failed to create SSL context in order to verify private key\n"
+ );
+
+ Net::SSLeay::set_cert_and_key($ctx, $cert_path, $key_path);
+
+ my $result = Net::SSLeay::CTX_check_private_key($ctx);
+
+ $ssl_warn->("Failed to validate private key and certificate\n")
+ if !$result;
+
+ Net::SSLeay::CTX_free($ctx);
+
+ return $result;
+}
+
sub get_certificate_info {
my ($cert_path) = @_;
--
2.30.2
next prev parent reply other threads:[~2023-02-28 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 16:36 [pve-devel] [PATCH-SERIES common/manager] Fix SSL Certificate and Key Upload Issues Max Carrara
2023-02-28 16:36 ` Max Carrara [this message]
2023-03-01 10:17 ` [pve-devel] [PATCH common 1/2] certificate: add subroutine that checks if cert and key match Fabian Grünbichler
2023-03-02 13:14 ` Max Carrara
2023-02-28 16:36 ` [pve-devel] [PATCH common 2/2] certificate: fix formatting and whitespace Max Carrara
2023-03-01 10:27 ` Fabian Grünbichler
2023-03-02 15:44 ` Max Carrara
2023-02-28 16:36 ` [pve-devel] [PATCH manager 1/2] fix #4552: certhelpers: check if custom cert and key match on change Max Carrara
2023-02-28 16:36 ` [pve-devel] [PATCH manager 2/2] ui: cert upload: fix private key field sending empty string Max Carrara
2023-03-01 9:35 ` Matthias Heiserer
2023-03-02 10:42 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228163634.299137-2-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox