public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 1/1] config: implement method to calculate derived properties from a config
Date: Tue, 28 Feb 2023 11:54:09 +0100	[thread overview]
Message-ID: <20230228105410.51078-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230228105410.51078-1-f.ebner@proxmox.com>

See the corresponding commit in guest-common for more information.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuConfig.pm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm
index 051382cd..10e69299 100644
--- a/PVE/QemuConfig.pm
+++ b/PVE/QemuConfig.pm
@@ -540,6 +540,22 @@ sub load_current_config {
     return $conf;
 }
 
+sub get_derived_property {
+    my ($class, $conf, $name) = @_;
+
+    my $defaults = PVE::QemuServer::load_defaults();
+
+    if ($name eq 'max-cpu') {
+	my $cpus =
+	    ($conf->{sockets} || $defaults->{sockets}) * ($conf->{cores} || $defaults->{cores});
+	return $conf->{vcpus} || $cpus;
+    } elsif ($name eq 'max-memory') {
+	return ($conf->{memory} || $defaults->{memory}) * 1024 * 1024;
+    } else {
+	die "unknown derived property - $name\n";
+    }
+}
+
 # END implemented abstract methods from PVE::AbstractConfig
 
 sub has_cloudinit {
-- 
2.30.2





  parent reply	other threads:[~2023-02-28 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 10:54 [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend on internal configuration details Fiona Ebner
2023-02-28 10:54 ` [pve-devel] [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config Fiona Ebner
2023-06-07 17:40   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH container 1/1] config: implement " Fiona Ebner
2023-06-09  5:50   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` Fiona Ebner [this message]
2023-06-08 15:59   ` [pve-devel] applied: Re: [PATCH qemu-server " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH ha-manager 1/1] resources: pve: avoid relying on internal configuration details Fiona Ebner
2023-06-06  6:42 ` [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228105410.51078-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal