public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config
Date: Tue, 28 Feb 2023 11:54:07 +0100	[thread overview]
Message-ID: <20230228105410.51078-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230228105410.51078-1-f.ebner@proxmox.com>

HA manager currently needs to know about internal details about the
configs and how the properties are calculated. With this method, those
details are abstracted away, allowing to change the configuration
structure. In particular, QemuConfig's 'memory' can be turned into
a property string without HA manager needing to know about it (once HA
manager switched to using this mehtod).

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/AbstractConfig.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index a0c0bc6..3d2c255 100644
--- a/src/PVE/AbstractConfig.pm
+++ b/src/PVE/AbstractConfig.pm
@@ -1158,6 +1158,15 @@ sub snapshot_rollback {
     $class->lock_config($vmid, $updatefn);
 }
 
+# Calculate a derived property from a configuration. Derived properties are:
+# max-cpu - maximum amount of CPUs the guest can currently use (can be a fraction)
+# max-memory - maximum amount of memory the guest can currently use
+sub get_derived_property {
+    my ($class, $conf, $name) = @_;
+
+    die "implement me - abstract method\n";
+}
+
 # bash completion helper
 
 sub snapshot_list {
-- 
2.30.2





  reply	other threads:[~2023-02-28 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 10:54 [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend on internal configuration details Fiona Ebner
2023-02-28 10:54 ` Fiona Ebner [this message]
2023-06-07 17:40   ` [pve-devel] applied: [PATCH guest-common 1/1] abstract config: add method to calculate derived properties from a config Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH container 1/1] config: implement " Fiona Ebner
2023-06-09  5:50   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH qemu-server " Fiona Ebner
2023-06-08 15:59   ` [pve-devel] applied: " Thomas Lamprecht
2023-02-28 10:54 ` [pve-devel] [PATCH ha-manager 1/1] resources: pve: avoid relying on internal configuration details Fiona Ebner
2023-06-06  6:42 ` [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228105410.51078-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal