[pve-devel] [PATCH v3 widget-toolkit 1/2] ui: SMART: fix eslint error / show correct value

[pve-devel] [PATCH v3 widget-toolkit 1/2] ui: SMART: fix eslint error / show correct value

[Matthias Heiserer]

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---

Changes from v2:
Calculate the field in a different way...

Thanks to dominik for simplifying/fixing the logic!

 src/window/DiskSmart.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index b538ea1..3824175 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -159,12 +159,12 @@ Ext.define('Proxmox.window.DiskSmart', {
 	    {
 		name: 'real-value',
 		// FIXME remove with next major release (PBS 3.0)
-		calculate: data => (data.normalized ?? false) ? data.raw : data.value,
+		calculate: data => data.raw ?? data.value,
 	    },
 	    {
 		name: 'real-normalized',
 		// FIXME remove with next major release (PBS 3.0)
-		calculate: data => data.normalized ?? data.raw,
+		calculate: data => data.normalized ?? data.value,
 	    },
 	],
 	idProperty: 'name',
-- 
2.30.2

[pve-devel] [PATCH v3 widget-toolkit 2/2] ui: SMART: rename Value to Raw Value

[Matthias Heiserer]

This should reduce confusion, as it uses the same naming as smartctl

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
Changes from v2:
new change

 src/window/DiskSmart.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index 3824175..ba64cfe 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -37,7 +37,7 @@ Ext.define('Proxmox.window.DiskSmart', {
 		    renderer: Ext.String.htmlEncode,
 		},
 		{
-		    text: gettext('Value'),
+		    text: gettext('Raw Value'),
 		    dataIndex: 'real-value',
 		    renderer: Ext.String.htmlEncode,
 		},
-- 
2.30.2

[pve-devel] applied: [PATCH v3 widget-toolkit 1/2] ui: SMART: fix eslint error / show correct value

[Thomas Lamprecht]

Am 24/02/2023 um 15:40 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> 
> Changes from v2:
> Calculate the field in a different way...
> 
> Thanks to dominik for simplifying/fixing the logic!
> 
>  src/window/DiskSmart.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied both patches (already a few days ago), thanks!