* [pve-devel] [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical
@ 2023-02-23 9:49 Fiona Ebner
2023-02-23 10:44 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2023-02-23 9:49 UTC (permalink / raw)
To: pve-devel
The guest will be running, so it's misleading to fail the start task
here. Also ensures that we clean up the hibernation state upon resume
even if there is an error here, which did not happen previously[0].
[0]: https://forum.proxmox.com/threads/123159/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer.pm | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a1a8b937..ff1e3c72 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6053,13 +6053,16 @@ sub vm_start_nolock {
}
if (!defined($conf->{balloon}) || $conf->{balloon}) {
- mon_cmd(
- $vmid,
- 'qom-set',
- path => "machine/peripheral/balloon0",
- property => "guest-stats-polling-interval",
- value => 2
- );
+ eval {
+ mon_cmd(
+ $vmid,
+ 'qom-set',
+ path => "machine/peripheral/balloon0",
+ property => "guest-stats-polling-interval",
+ value => 2
+ );
+ };
+ log_warn("could not set polling interval for ballooning - $@") if $@;
}
if ($resume) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-23 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 9:49 [pve-devel] [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical Fiona Ebner
2023-02-23 10:44 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox