From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-acme 2/2] tests: add non-word boundary to present functions
Date: Tue, 21 Feb 2023 14:13:18 +0100 [thread overview]
Message-ID: <20230221131318.4043599-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20230221131318.4043599-1-s.ivanov@proxmox.com>
noticed that _clearaccountconf_mutable is used in dns_cf.sh, but not
present (it gets masked since we provide _clearaccountconf)
tested with this example.
additionally update missing-functions.expected - _error is not
present in upstream `acme.sh` but used in dns_aws.sh (I expect an
error which is only hit very seldomly)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/test/check-missing-functions | 4 ++--
src/test/missing-functions.expected | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/test/check-missing-functions b/src/test/check-missing-functions
index cb819fc..dfc32d3 100755
--- a/src/test/check-missing-functions
+++ b/src/test/check-missing-functions
@@ -3,11 +3,11 @@
set -e
# functions already in src/proxmox-acme
-PRESENT=$(awk 'BEGIN{ORS="|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
+PRESENT=$(awk 'BEGIN{ORS="\\W|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
../proxmox-acme | sed -r 's/\|$//')
# functions defined in all plugins
-LOCAL=$(awk 'BEGIN{ORS="|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
+LOCAL=$(awk 'BEGIN{ORS="\\W|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
../acme.sh/dnsapi/dns*.sh | sed -r 's/\|$//')
grep -P '(?<!["$])\b_[a-zA-Z0-9_-]+ ' ../acme.sh/dnsapi/dns_*sh | \
diff --git a/src/test/missing-functions.expected b/src/test/missing-functions.expected
index 467f9ac..5c2b053 100644
--- a/src/test/missing-functions.expected
+++ b/src/test/missing-functions.expected
@@ -1,3 +1,4 @@
+../acme.sh/dnsapi/dns_aws.sh: _error "invalid domain"
../acme.sh/dnsapi/dns_cpanel.sh: for _domain in $_domains; do
../acme.sh/dnsapi/dns_cyon.sh: printf "%s" "${_dns_entries}" | while read -r _hash _identifier; do
../acme.sh/dnsapi/dns_do.sh: for _rrid in ${_rr_list}; do
--
2.30.2
next prev parent reply other threads:[~2023-02-21 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 13:13 [pve-devel] [PATCH proxmox-acme 0/2] add missing _clearaccountconf_mutable and improve check-missing script Stoiko Ivanov
2023-02-21 13:13 ` [pve-devel] [PATCH proxmox-acme 1/2] proxmox-acme: add empty _clearaccountconf_mutable helper Stoiko Ivanov
2023-02-21 13:13 ` Stoiko Ivanov [this message]
2023-02-21 16:29 ` [pve-devel] applied: [PATCH proxmox-acme 0/2] add missing _clearaccountconf_mutable and improve check-missing script Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221131318.4043599-3-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox