From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected
Date: Mon, 20 Feb 2023 13:33:06 +0100 [thread overview]
Message-ID: <20230220123306.nsghztog6ec4mw4p@casey.proxmox.com> (raw)
In-Reply-To: <20230220115155.q2mceyrpa7qubdjp@maui.proxmox.com>
On Mon, Feb 20, 2023 at 12:51:55PM +0100, Christoph Heiss wrote:
> On Fri, Feb 17, 2023 at 05:38:57PM +0100, Thomas Lamprecht wrote:
> > Am 17/02/2023 um 15:51 schrieb Wolfgang Bumiller:
> > >> * Rename option to kebap-case
> > > Sorry I missed that when Thomas replied to the v1.
> > > This is a case where the property already exists in the VM api, so
> > > better reuse the snake_case version here. @Thomas?
> > >
> >
> > I assumed that, that's why I asked if keeping it that way would help to reuse some
> > code infra; not sure about how useful it is to keep it for API consumers to keep it
> > the same as in a quite different API end point,
> There really is no code-reuse between those two endpoints, so it made
> sense to me too to rename it.
It's more about possible code reuse in front-ends rather than in the
backend though, where a set of common options with common code to
fill/read/... them can definitely be a thing ;-)
>
> > but I see where you come from and don't
> > insist for going with snake-case, so if you think using the same style here has benefits.
> > we can ignore the guidance that new params should always use kebab-case.
> .. but I will rename it back to snake_case for v3, since that seems to
> be consensus here?
Given Thomas' plan to rename stuff in the future, I'd say yes, for now.
next prev parent reply other threads:[~2023-02-20 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 14:02 [pve-devel] [PATCH v2 container/manager 0/4] fix #3413: Add `Disconnect` option for LXC networks Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 1/4] lxc: Fix some trailing whitespace Christoph Heiss
2023-02-17 14:22 ` Wolfgang Bumiller
2023-02-20 11:13 ` Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 2/4] lxc: Avoid open-coding normal vs SDN-specific tap_plug() Christoph Heiss
2023-02-17 14:34 ` Wolfgang Bumiller
2023-02-20 11:17 ` Christoph Heiss
2023-02-15 14:02 ` [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected Christoph Heiss
2023-02-17 14:51 ` Wolfgang Bumiller
2023-02-17 16:38 ` Thomas Lamprecht
2023-02-20 11:51 ` Christoph Heiss
2023-02-20 12:33 ` Wolfgang Bumiller [this message]
2023-02-20 12:37 ` Thomas Lamprecht
2023-02-15 14:02 ` [pve-devel] [PATCH v2 manager 4/4] lxc: Add `Disconnect` option for network interfaces Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220123306.nsghztog6ec4mw4p@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox