public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu 2/2] d/rules: add note explaining why using noopt doesn't currenlty work
Date: Fri, 10 Feb 2023 10:39:24 +0100	[thread overview]
Message-ID: <20230210093924.64178-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230210093924.64178-1-f.ebner@proxmox.com>

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 7fa9911..e69ba47 100755
--- a/debian/rules
+++ b/debian/rules
@@ -29,6 +29,9 @@ BUILDDIR=build
 
 CFLAGS = -Wall
 
+# FIXME: There is a second -02 added because of meson.build in the subproject
+# and that is appended after -O0 from here (last -O wins), so supporting noopt
+# doesn't work like this.
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -O0
 else
-- 
2.30.2





  reply	other threads:[~2023-02-10  9:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  9:39 [pve-devel] [PATCH qemu 1/2] d/rules: add missing export for CFLAGS Fiona Ebner
2023-02-10  9:39 ` Fiona Ebner [this message]
2023-02-14  9:07 ` [pve-devel] applied: " Thomas Lamprecht
2023-02-15 12:03   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230210093924.64178-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal