[pve-devel] [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

[pve-devel] [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

[Fiona Ebner]

Otherwise, they don't affect the build of QEMU at all.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 6d5f882..7fa9911 100755
--- a/debian/rules
+++ b/debian/rules
@@ -35,6 +35,8 @@ else
 	CFLAGS += -O2
 endif
 
+export CFLAGS
+
 ${BUILDDIR}/config.status: configure
 	dh_testdir
 	# Add here commands to configure the package.
-- 
2.30.2

[pve-devel] [PATCH qemu 2/2] d/rules: add note explaining why using noopt doesn't currenlty work

[Fiona Ebner]

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 7fa9911..e69ba47 100755
--- a/debian/rules
+++ b/debian/rules
@@ -29,6 +29,9 @@ BUILDDIR=build
 
 CFLAGS = -Wall
 
+# FIXME: There is a second -02 added because of meson.build in the subproject
+# and that is appended after -O0 from here (last -O wins), so supporting noopt
+# doesn't work like this.
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -O0
 else
-- 
2.30.2

[pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

[Thomas Lamprecht]

On 10/02/2023 10:39, Fiona Ebner wrote:
> Otherwise, they don't affect the build of QEMU at all.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  debian/rules | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!

not sure how many use the `noopt`, on debugging - for what it's mostly useful,
building directly in the upstream source tree seems more fitting anyway, especially
for modify-build-test runs or bisects. Maybe we could just drop any mention of it?  

Re: [pve-devel] applied: Re: [PATCH qemu 1/2] d/rules: add missing export for CFLAGS

[Fiona Ebner]

Am 14.02.23 um 10:07 schrieb Thomas Lamprecht:
> On 10/02/2023 10:39, Fiona Ebner wrote:
>> Otherwise, they don't affect the build of QEMU at all.
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>  debian/rules | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>>
> 
> applied, thanks!
> 
> not sure how many use the `noopt`, on debugging - for what it's mostly useful,
> building directly in the upstream source tree seems more fitting anyway, especially
> for modify-build-test runs or bisects. Maybe we could just drop any mention of it?  

Fine by me too. We could also make it work by using the --enable-debug
configure switch (stumbled upon that yesterday). Whichever you prefer.