[pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories

[pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories

[Leo Nunner]

Changes from v1:
    - Rebase docs so that it applies again
    - Use gettext instead of a plain string in the manager patch

manager:

Leo Nunner (1):
  fix #2641: expose CIFS subdir parameter through GUI

 www/manager6/storage/CIFSEdit.js | 11 +++++++++++
 1 file changed, 11 insertions(+)

docs:

Leo Nunner (1):
  fix #2641: document subdir parameter for CIFS backend

 pve-storage-cifs.adoc | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.30.2

[pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI

[Leo Nunner]

makes it possible to optionally set the 'subdir' parameter when adding a
new CIFS storage.

Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
Changes from v1:
    - use gettext for the Subdirectory label

 www/manager6/storage/CIFSEdit.js | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/www/manager6/storage/CIFSEdit.js b/www/manager6/storage/CIFSEdit.js
index 71415401..8040bc85 100644
--- a/www/manager6/storage/CIFSEdit.js
+++ b/www/manager6/storage/CIFSEdit.js
@@ -129,6 +129,9 @@ Ext.define('PVE.storage.CIFSInputPanel', {
 	if (values.username?.length === 0) {
 	    delete values.username;
 	}
+	if (values.subdir?.length === 0) {
+	    delete values.subdir;
+	}
 
 	return me.callParent([values]);
     },
@@ -216,6 +219,14 @@ Ext.define('PVE.storage.CIFSInputPanel', {
 		    },
 		},
 	    },
+	    {
+		xtype: 'pmxDisplayEditField',
+		editable: me.isCreate,
+		name: 'subdir',
+		fieldLabel: gettext('Subdirectory'),
+		allowBlank: true,
+		emptyText: gettext('/some/path'),
+	    },
 	];
 
 	me.callParent();
-- 
2.30.2

[pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend

[Leo Nunner]

Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
 pve-storage-cifs.adoc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
index e0d4106..df63b58 100644
--- a/pve-storage-cifs.adoc
+++ b/pve-storage-cifs.adoc
@@ -61,6 +61,10 @@ content-dirs::
 
 Overrides for the default directory layout. Optional.
 
+subdir::
+
+The subdirectory of the share to mount. Optional, defaults to the root directory of the share.
+
 .Configuration Example (`/etc/pve/storage.cfg`)
 ----
 cifs: backup
@@ -70,6 +74,7 @@ cifs: backup
 	content backup
 	username anna
 	smbversion 3
+	subdir /data
 
 ----
 
-- 
2.30.2

[pve-devel] applied: [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend

[Thomas Lamprecht]

Am 08/02/2023 um 10:05 schrieb Leo Nunner:
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
>  pve-storage-cifs.adoc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
>

applied, thanks!

[pve-devel] applied: [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI

[Thomas Lamprecht]

Am 08/02/2023 um 10:05 schrieb Leo Nunner:
> makes it possible to optionally set the 'subdir' parameter when adding a
> new CIFS storage.
> 
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> Changes from v1:
>     - use gettext for the Subdirectory label
> 
>  www/manager6/storage/CIFSEdit.js | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
>

applied, thanks!