* [pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories
@ 2023-02-08 9:05 Leo Nunner
2023-02-08 9:05 ` [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI Leo Nunner
2023-02-08 9:05 ` [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend Leo Nunner
0 siblings, 2 replies; 5+ messages in thread
From: Leo Nunner @ 2023-02-08 9:05 UTC (permalink / raw)
To: pve-devel
Changes from v1:
- Rebase docs so that it applies again
- Use gettext instead of a plain string in the manager patch
manager:
Leo Nunner (1):
fix #2641: expose CIFS subdir parameter through GUI
www/manager6/storage/CIFSEdit.js | 11 +++++++++++
1 file changed, 11 insertions(+)
docs:
Leo Nunner (1):
fix #2641: document subdir parameter for CIFS backend
pve-storage-cifs.adoc | 5 +++++
1 file changed, 5 insertions(+)
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI
2023-02-08 9:05 [pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories Leo Nunner
@ 2023-02-08 9:05 ` Leo Nunner
2023-06-06 15:08 ` [pve-devel] applied: " Thomas Lamprecht
2023-02-08 9:05 ` [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend Leo Nunner
1 sibling, 1 reply; 5+ messages in thread
From: Leo Nunner @ 2023-02-08 9:05 UTC (permalink / raw)
To: pve-devel
makes it possible to optionally set the 'subdir' parameter when adding a
new CIFS storage.
Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
Changes from v1:
- use gettext for the Subdirectory label
www/manager6/storage/CIFSEdit.js | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/www/manager6/storage/CIFSEdit.js b/www/manager6/storage/CIFSEdit.js
index 71415401..8040bc85 100644
--- a/www/manager6/storage/CIFSEdit.js
+++ b/www/manager6/storage/CIFSEdit.js
@@ -129,6 +129,9 @@ Ext.define('PVE.storage.CIFSInputPanel', {
if (values.username?.length === 0) {
delete values.username;
}
+ if (values.subdir?.length === 0) {
+ delete values.subdir;
+ }
return me.callParent([values]);
},
@@ -216,6 +219,14 @@ Ext.define('PVE.storage.CIFSInputPanel', {
},
},
},
+ {
+ xtype: 'pmxDisplayEditField',
+ editable: me.isCreate,
+ name: 'subdir',
+ fieldLabel: gettext('Subdirectory'),
+ allowBlank: true,
+ emptyText: gettext('/some/path'),
+ },
];
me.callParent();
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend
2023-02-08 9:05 [pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories Leo Nunner
2023-02-08 9:05 ` [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI Leo Nunner
@ 2023-02-08 9:05 ` Leo Nunner
2023-03-21 11:32 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 1 reply; 5+ messages in thread
From: Leo Nunner @ 2023-02-08 9:05 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
pve-storage-cifs.adoc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
index e0d4106..df63b58 100644
--- a/pve-storage-cifs.adoc
+++ b/pve-storage-cifs.adoc
@@ -61,6 +61,10 @@ content-dirs::
Overrides for the default directory layout. Optional.
+subdir::
+
+The subdirectory of the share to mount. Optional, defaults to the root directory of the share.
+
.Configuration Example (`/etc/pve/storage.cfg`)
----
cifs: backup
@@ -70,6 +74,7 @@ cifs: backup
content backup
username anna
smbversion 3
+ subdir /data
----
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied: [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend
2023-02-08 9:05 ` [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend Leo Nunner
@ 2023-03-21 11:32 ` Thomas Lamprecht
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2023-03-21 11:32 UTC (permalink / raw)
To: Proxmox VE development discussion, Leo Nunner
Am 08/02/2023 um 10:05 schrieb Leo Nunner:
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> pve-storage-cifs.adoc | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied: [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI
2023-02-08 9:05 ` [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI Leo Nunner
@ 2023-06-06 15:08 ` Thomas Lamprecht
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2023-06-06 15:08 UTC (permalink / raw)
To: Proxmox VE development discussion, Leo Nunner
Am 08/02/2023 um 10:05 schrieb Leo Nunner:
> makes it possible to optionally set the 'subdir' parameter when adding a
> new CIFS storage.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> Changes from v1:
> - use gettext for the Subdirectory label
>
> www/manager6/storage/CIFSEdit.js | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-06 15:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 9:05 [pve-devel] [PATCH v2 manager] Allow mounting of CIFS subdirectories Leo Nunner
2023-02-08 9:05 ` [pve-devel] [PATCH v2 manager] fix #2641: expose CIFS subdir parameter through GUI Leo Nunner
2023-06-06 15:08 ` [pve-devel] applied: " Thomas Lamprecht
2023-02-08 9:05 ` [pve-devel] [PATCH v2 docs] fix #2641: document subdir parameter for CIFS backend Leo Nunner
2023-03-21 11:32 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox