public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server/manager/docs 0/3] fix #4140: Add option to disable `fs-freeze`/`-thaw` on backup
Date: Wed,  1 Feb 2023 13:59:15 +0100	[thread overview]
Message-ID: <20230201125918.372665-1-c.heiss@proxmox.com> (raw)

TL;DR: on Windows guests, the guest agent calls into the VSS (Volume
Shadow Copy) subsystem, which has potential to mess up applications
which hook into this themselves like SQL server, as described in the bug
report [0].

Building upon the proposal in that report, add an (default-enabled)
option to the QGA configuration to disable the behavior if really
needed. Due to its potential to wreak havor, show the user a warning
when disabled.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4140

Christoph Heiss (1):
      vzdump: Add VM QGA option to skip `fs-freeze`/`fs-thaw` on backup

 PVE/QemuServer.pm        | 8 +++++++-
 PVE/VZDump/QemuServer.pm | 5 +++++
 2 files changed, 12 insertions(+), 1 deletion(-)

Christoph Heiss (1):
      ui: qga: Add option to turn off fs-freeze/thaw for backup

 www/manager6/Utils.js                     |  2 ++
 www/manager6/form/AgentFeatureSelector.js | 30 +++++++++++++++++++++++++++++-
 2 files changed, 31 insertions(+), 1 deletion(-)

Christoph Heiss (1):
      qm: Add section explaining fs-freeze/thaw QGA option

 qm.adoc | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

--
2.39.1





             reply	other threads:[~2023-02-01 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 12:59 Christoph Heiss [this message]
2023-02-01 12:59 ` [pve-devel] [PATCH qemu-server 1/3] vzdump: Add VM QGA option to skip `fs-freeze`/`fs-thaw` " Christoph Heiss
2023-02-23 10:55   ` Thomas Lamprecht
2023-02-23 11:29     ` Christoph Heiss
2023-02-01 12:59 ` [pve-devel] [PATCH manager 2/3] ui: qga: Add option to turn off fs-freeze/thaw for backup Christoph Heiss
2023-02-01 12:59 ` [pve-devel] [PATCH docs 3/3] qm: Add section explaining fs-freeze/thaw QGA option Christoph Heiss
2023-02-23 11:34   ` Thomas Lamprecht
2023-02-23 12:10     ` Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230201125918.372665-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal