public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH access-control/docs 0/2] fix #3748: Allow reserved characters in attribute values of LDAP DNs
Date: Tue, 31 Jan 2023 13:50:41 +0100	[thread overview]
Message-ID: <20230131125043.380402-1-c.heiss@proxmox.com> (raw)

This fixes #3748 [0] by allowing reserved characters in `bind_dn` (and
other properties of the same format) if they are properly quoted and
adds some corresponding documentation regarding that.

This was tested by setting up a slapd server and creating a user with
the CN `Test, User` much like in the bug report, then using this user as
`bind_dn` in the sync options. I also tested some variants of that CN,
including just `TestUser`.)

One thing that still won't work is syncing of LDAP users with colons or
slashes in their CNs. In such cases, the message

  value 'Test, User@ldap' does not look like a valid user name

will pop up.

This is due to spaces and colons being explicitly disallowed in
usernames [1]. This probably means that such names can never be allowed,
which is being documented too as part of patch 2.

But with this series, such users can be at least used to bind for
syncing.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=3748
[1] https://git.proxmox.com/?p=pve-access-control.git;a=blob;f=src/PVE/Auth/Plugin.pm;hb=HEAD#l115

Christoph Heiss (1):
      ldap: Allow quoted values for DN attribute values

 src/PVE/Auth/LDAP.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Christoph Heiss (1):
      pveum: Document reserved characters and quoting of LDAP DNs

 pveum.adoc | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

--
2.34.1





             reply	other threads:[~2023-01-31 12:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 12:50 Christoph Heiss [this message]
2023-01-31 12:50 ` [pve-devel] [PATCH access-control 1/2] ldap: Allow quoted values for DN attribute values Christoph Heiss
2023-03-15  9:54   ` Dominik Csapak
2023-03-15 11:17     ` Christoph Heiss
2023-03-15 11:41       ` Dominik Csapak
2023-03-15 12:07         ` Christoph Heiss
2023-03-15 12:12         ` Thomas Lamprecht
2023-03-20 15:09     ` [pve-devel] applied: " Thomas Lamprecht
2023-01-31 12:50 ` [pve-devel] [PATCH docs 2/2] pveum: Document reserved characters and quoting of LDAP DNs Christoph Heiss
2023-03-20 16:01   ` [pve-devel] applied: " Thomas Lamprecht
2023-03-14  9:48 ` [pve-devel] [PATCH access-control/docs 0/2] fix #3748: Allow reserved characters in attribute values " Christoph Heiss
2023-03-20 14:22 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131125043.380402-1-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal