public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Leo Nunner <l.nunner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 firewall] fix #4414: automatically rename usages of aliases and IPsets
Date: Thu, 26 Jan 2023 15:31:25 +0100	[thread overview]
Message-ID: <20230126143127.151018-1-l.nunner@proxmox.com> (raw)

This patch depends on my previous patch removing capitalization
restrictions [1].

Changes from v1:
    - factor in feedback from v1 
    - fix issues that arose from renaming objects and changing their
      capitalization. This is a separate patch, since it would exceed
      the scope of this one. Rebased accordingly.

      Note that this patch depends on _all_ the patches in [1], so also
      the optional one. In case that isn't needed, I'll rebase this
      patch.

[1] https://lists.proxmox.com/pipermail/pve-devel/2023-January/055596.html

firewall:

Leo Nunner (2):
  allow updating an alias without providing a CIDR
  fix #4414: automatically rename usages of aliases and IPsets

 src/PVE/API2/Firewall/Aliases.pm | 53 ++++++++++++++++++++++++++++---
 src/PVE/API2/Firewall/Groups.pm  | 54 ++++++--------------------------
 src/PVE/API2/Firewall/IPSet.pm   | 47 +++++++++++++++++++++++++--
 src/PVE/Firewall/Helpers.pm      | 33 +++++++++++++++++++
 4 files changed, 136 insertions(+), 51 deletions(-)

-- 
2.30.2





             reply	other threads:[~2023-01-26 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 14:31 Leo Nunner [this message]
2023-01-26 14:31 ` [pve-devel] [PATCH v2 firewall 1/2] allow updating an alias without providing a CIDR Leo Nunner
2023-01-26 14:31 ` [pve-devel] [PATCH v2 firewall 2/2] fix #4414: automatically rename usages of aliases and IPsets Leo Nunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126143127.151018-1-l.nunner@proxmox.com \
    --to=l.nunner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal