From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with icons
Date: Thu, 26 Jan 2023 11:47:09 +0100 [thread overview]
Message-ID: <20230126104711.377316-1-l.wagner@proxmox.com> (raw)
In our UI, we've been a bit inconsistent with the use of checkboxes/text
for `enabled` properties in table views. Looking through the UI, I've
found that the following UI elements use a checkbox UI control to
indicate wheter something is enabled or not:
* backup job overview
* APT repository overview
* replication job overview
While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing). Now, for the three UI elements mentioned above, I would
say it is a good thing that they are not manipulateable from the overview,
in order to avoid any accidental modifications.
In this patch series, the checkbox is replaced by a checkmark
(fa-check) icon if enabled, or by a minus/dash (fa-minus) icon if disabled.
Note: Firewall configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox.
As mentioned by Thomas in v1, this could be replaced by a more explicit
icon-based toggle button in a future series.
Changes v2 -> v3:
* Fixed typo 'dataindex' -> 'dataIndex'
* Use camel case for render function
* Use arrow functions
* Remove spurious newline
proxmox-widget-toolkit:
Lukas Wagner (1):
repo view: replace non-clickable checkbox with icons
src/Utils.js | 2 ++
src/node/APTRepositories.js | 6 ++----
2 files changed, 4 insertions(+), 4 deletions(-)
pve-manager:
Lukas Wagner (1):
ui: backup: replication: replace non-clickable checkbox with icons
www/manager6/dc/Backup.js | 7 +++----
www/manager6/grid/Replication.js | 7 ++++---
2 files changed, 7 insertions(+), 7 deletions(-)
--
2.30.2
next reply other threads:[~2023-01-26 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:47 Lukas Wagner [this message]
2023-01-26 10:47 ` [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox " Lukas Wagner
2023-03-17 11:04 ` [pve-devel] applied: " Thomas Lamprecht
2023-01-26 10:47 ` [pve-devel] [PATCH v3 manager 2/2] ui: backup: replication: " Lukas Wagner
2023-03-17 11:04 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126104711.377316-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox