public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: cluster info: fix displaying error
Date: Mon, 23 Jan 2023 14:45:08 +0100	[thread overview]
Message-ID: <20230123134508.121996-1-f.ebner@proxmox.com> (raw)

The function to set the error mask expects the message as a string,
not the error object.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/dc/Cluster.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/Cluster.js b/www/manager6/dc/Cluster.js
index afe14bf4..22b62cc8 100644
--- a/www/manager6/dc/Cluster.js
+++ b/www/manager6/dc/Cluster.js
@@ -72,7 +72,7 @@ Ext.define('PVE.ClusterAdministration', {
 			    let msg = Proxmox.Utils.getResponseErrorMessage(error);
 			    if (error.status !== 424 && !msg.match(/node is not in a cluster/i)) {
 				// an actual error, not just the "not in a cluster one", so show it!
-				Proxmox.Utils.setErrorMask(this.getView(), error);
+				Proxmox.Utils.setErrorMask(this.getView(), msg);
 			    }
 			}
 			vm.set('totem', {});
-- 
2.30.2





             reply	other threads:[~2023-01-23 13:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 13:45 Fiona Ebner [this message]
2023-01-24 15:15 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123134508.121996-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal