From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace non-clickable checkbox with icons
Date: Mon, 23 Jan 2023 14:17:35 +0100 [thread overview]
Message-ID: <20230123131735.400368-3-l.wagner@proxmox.com> (raw)
In-Reply-To: <20230123131735.400368-1-l.wagner@proxmox.com>
From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/Backup.js | 11 ++++++-----
www/manager6/grid/Replication.js | 11 +++++++----
2 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 9d305984..8a306330 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -784,12 +784,13 @@ Ext.define('PVE.dc.BackupView', {
{
header: gettext('Enabled'),
width: 80,
- dataIndex: 'enabled',
- xtype: 'checkcolumn',
+ dataindex: 'enabled',
+ align: 'center',
+ renderer: function(enabled, cell, record) {
+ return Proxmox.Utils.render_enabled_icon(record.data.enabled);
+ },
sortable: true,
- disabled: true,
- disabledCls: 'x-item-enabled',
- stopSelection: false,
+
},
{
header: gettext('ID'),
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index b17288b9..261c2755 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -279,11 +279,14 @@ Ext.define('PVE.grid.ReplicaView', {
me.columns = [
{
- text: gettext('Enabled'),
- dataIndex: 'enabled',
- xtype: 'checkcolumn',
+ header: gettext('Enabled'),
+ width: 80,
+ dataindex: 'enabled',
+ align: 'center',
+ renderer: function(enabled, cell, record) {
+ return Proxmox.Utils.render_enabled_icon(record.data.enabled);
+ },
sortable: true,
- disabled: true,
},
{
text: 'ID',
--
2.30.2
next prev parent reply other threads:[~2023-01-23 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
2023-01-24 15:24 ` Thomas Lamprecht
2023-01-24 15:30 ` Thomas Lamprecht
2023-01-23 13:17 ` Lukas Wagner [this message]
2023-01-24 15:28 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Thomas Lamprecht
2023-01-24 15:37 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123131735.400368-3-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox