From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox with icons
Date: Mon, 23 Jan 2023 14:17:34 +0100 [thread overview]
Message-ID: <20230123131735.400368-2-l.wagner@proxmox.com> (raw)
In-Reply-To: <20230123131735.400368-1-l.wagner@proxmox.com>
From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/Utils.js | 6 ++++++
src/node/APTRepositories.js | 8 ++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index ef0c2b8..5397fd9 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -100,6 +100,11 @@ utilities: {
return value;
},
+ render_enabled_icon: function(value) {
+ let icon = value ? 'fa-check' : 'fa-minus';
+ return `<i class="fa ${icon}"></i>`;
+ },
+
language_array: function() {
let data = [['__default__', Proxmox.Utils.render_language('')]];
Ext.Object.each(Proxmox.Utils.language_map, function(key, value) {
@@ -145,6 +150,7 @@ utilities: {
return value ? Proxmox.Utils.enabledText : Proxmox.Utils.disabledText;
},
+
format_expire: function(date) {
if (!date) {
return Proxmox.Utils.neverText;
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index ce8f718..c6b45a2 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -239,11 +239,11 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
columns: [
{
- xtype: 'checkcolumn',
header: gettext('Enabled'),
- dataIndex: 'Enabled',
- listeners: {
- beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle
+ dataindex: 'Enabled',
+ align: 'center',
+ renderer: function(enabled, cell, record) {
+ return Proxmox.Utils.render_enabled_icon(record.data.Enabled);
},
width: 90,
},
--
2.30.2
next prev parent reply other threads:[~2023-01-23 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-23 13:17 ` Lukas Wagner [this message]
2023-01-24 15:24 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Thomas Lamprecht
2023-01-24 15:30 ` Thomas Lamprecht
2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
2023-01-24 15:28 ` Thomas Lamprecht
2023-01-24 15:37 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123131735.400368-2-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox