public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] schema: memory: be precise that unit is binary prefix
@ 2023-01-23  9:46 Fiona Ebner
  2023-01-24 16:10 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2023-01-23  9:46 UTC (permalink / raw)
  To: pve-devel

In the web UI, this was fixed years ago by pve-manager commit c11c4a40
("fix #1631: change units to binary prefix").

Quickly checked with the 'query-memory-size-summary' QMP command that
this is actually the case.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 99242d54..6a29d1bf 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -342,7 +342,7 @@ my $confdesc = {
     memory => {
 	optional => 1,
 	type => 'integer',
-	description => "Amount of RAM for the VM in MB. This is the maximum available memory when"
+	description => "Amount of RAM for the VM in MiB. This is the maximum available memory when"
 	    ." you use the balloon device.",
 	minimum => 16,
 	default => 512,
@@ -350,7 +350,7 @@ my $confdesc = {
     balloon => {
 	optional => 1,
 	type => 'integer',
-	description => "Amount of target RAM for the VM in MB. Using zero disables the ballon driver.",
+	description => "Amount of target RAM for the VM in MiB. Using zero disables the ballon driver.",
 	minimum => 0,
     },
     shares => {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-24 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23  9:46 [pve-devel] [PATCH qemu-server] schema: memory: be precise that unit is binary prefix Fiona Ebner
2023-01-24 16:10 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal