public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] schema: memory: be precise that unit is binary prefix
Date: Mon, 23 Jan 2023 10:46:38 +0100	[thread overview]
Message-ID: <20230123094638.63892-1-f.ebner@proxmox.com> (raw)

In the web UI, this was fixed years ago by pve-manager commit c11c4a40
("fix #1631: change units to binary prefix").

Quickly checked with the 'query-memory-size-summary' QMP command that
this is actually the case.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 PVE/QemuServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 99242d54..6a29d1bf 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -342,7 +342,7 @@ my $confdesc = {
     memory => {
 	optional => 1,
 	type => 'integer',
-	description => "Amount of RAM for the VM in MB. This is the maximum available memory when"
+	description => "Amount of RAM for the VM in MiB. This is the maximum available memory when"
 	    ." you use the balloon device.",
 	minimum => 16,
 	default => 512,
@@ -350,7 +350,7 @@ my $confdesc = {
     balloon => {
 	optional => 1,
 	type => 'integer',
-	description => "Amount of target RAM for the VM in MB. Using zero disables the ballon driver.",
+	description => "Amount of target RAM for the VM in MiB. Using zero disables the ballon driver.",
 	minimum => 0,
     },
     shares => {
-- 
2.30.2





             reply	other threads:[~2023-01-23  9:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  9:46 Fiona Ebner [this message]
2023-01-24 16:10 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123094638.63892-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal