* [pve-devel] [PATCH manager] ui: fix search for 'Guests without Backup' window
@ 2023-01-20 8:47 Lukas Wagner
2023-01-20 8:56 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-01-20 8:47 UTC (permalink / raw)
To: pve-devel
In JS, a `for (const a in <...>)` loop iterates over indices, not
over values. To iterate over values, `for (const a of <..>)` has
to be used. Furthermore, filtering by ID did not work properly, since
the property is called `vmid`, not `id`.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/BackupJobDetail.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
index c82f50f4..c4683a47 100644
--- a/www/manager6/dc/BackupJobDetail.js
+++ b/www/manager6/dc/BackupJobDetail.js
@@ -460,7 +460,7 @@ Ext.define('PVE.dc.BackedGuests', {
me.store.clearFilter(true);
me.store.filterBy(function(record) {
let data = record.data;
- for (const property in ['name', 'id', 'type']) {
+ for (const property of ['name', 'vmid', 'type']) {
if (data[property] === null) {
continue;
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: fix search for 'Guests without Backup' window
2023-01-20 8:47 [pve-devel] [PATCH manager] ui: fix search for 'Guests without Backup' window Lukas Wagner
@ 2023-01-20 8:56 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-01-20 8:56 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 20/01/2023 um 09:47 schrieb Lukas Wagner:
> In JS, a `for (const a in <...>)` loop iterates over indices, not
> over values. To iterate over values, `for (const a of <..>)` has
> to be used. Furthermore, filtering by ID did not work properly, since
> the property is called `vmid`, not `id`.
seems it was not adapted when copying over from the job detail window
code.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/dc/BackupJobDetail.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-20 8:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 8:47 [pve-devel] [PATCH manager] ui: fix search for 'Guests without Backup' window Lukas Wagner
2023-01-20 8:56 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox