public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit/pve-manager] move node selection into combogrid
Date: Wed, 18 Jan 2023 14:12:55 +0100	[thread overview]
Message-ID: <20230118131303.2892050-1-d.csapak@proxmox.com> (raw)

instead of having it as a seperate input on storage creation.
This aims to reduce confusion about what it exactly is and how it
interacts with the rest of the input fields.

With this series, it sits in a toolbar of the relevant dropdown, which
were converted to combogrids. The selection box is only shown if the
number of nodes in the cluster is greater than one.

for accomodating the toolbar, we have to make 2 slight adaptions to the
combogrid

patch 3,4,5,6 of pve-manager are mostly cleanups and are not strictly
necessary for this series to work, but since i touched the files anyway,
i converted them to our 'modern' js style

The cleanups come after the change, because thats the order in which i wrote
it. If wanted i can send the cleanups seperately for the current master,
and rebase the changes for the node selection on top.

proxmox-widget-toolkit:

Dominik Csapak (2):
  ComboGrid: use the grids view for the error message
  ComboGrid: make height for the error configurable

 src/form/ComboGrid.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

pve-manager:

Dominik Csapak (6):
  ui: StorageScanNodeSelector: use null as empty value
  ui: storage: move node scan selector inside combobox
  ui: storage/LvmThinInputPanel: modernize & cleanup code
  ui: storage/IScsiInputPanel: modernize, cleanup & improve panel
  ui: storage/ZFSPoolInputPanel: modernize & cleanup code
  ui: storage/LVMInputPanel: modernize & cleanup code

 www/manager6/form/ComboBoxSetStoreNode.js    |  45 +++-
 www/manager6/form/StorageScanNodeSelector.js |   8 +-
 www/manager6/storage/IScsiEdit.js            | 129 +++++++-----
 www/manager6/storage/LVMEdit.js              | 209 +++++++++++--------
 www/manager6/storage/LvmThinEdit.js          | 150 +++++++------
 www/manager6/storage/ZFSPoolEdit.js          | 100 +++++----
 6 files changed, 361 insertions(+), 280 deletions(-)

-- 
2.30.2





             reply	other threads:[~2023-01-18 13:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 13:12 Dominik Csapak [this message]
2023-01-18 13:12 ` [pve-devel] [PATCH widget-toolkit 1/2] ComboGrid: use the grids view for the error message Dominik Csapak
2023-01-18 13:12 ` [pve-devel] [PATCH widget-toolkit 2/2] ComboGrid: make height for the error configurable Dominik Csapak
2023-01-18 13:12 ` [pve-devel] [PATCH manager 1/6] ui: StorageScanNodeSelector: use null as empty value Dominik Csapak
2023-01-18 13:12 ` [pve-devel] [PATCH manager 2/6] ui: storage: move node scan selector inside combobox Dominik Csapak
2023-01-18 13:13 ` [pve-devel] [PATCH manager 3/6] ui: storage/LvmThinInputPanel: modernize & cleanup code Dominik Csapak
2023-01-18 13:13 ` [pve-devel] [PATCH manager 4/6] ui: storage/IScsiInputPanel: modernize, cleanup & improve panel Dominik Csapak
2023-01-18 13:13 ` [pve-devel] [PATCH manager 5/6] ui: storage/ZFSPoolInputPanel: modernize & cleanup code Dominik Csapak
2023-01-18 13:13 ` [pve-devel] [PATCH manager 6/6] ui: storage/LVMInputPanel: " Dominik Csapak
2023-01-18 15:08 ` [pve-devel] applied-series: [PATCH widget-toolkit/pve-manager] move node selection into combogrid Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118131303.2892050-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal