[pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

[pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

[Christoph Heiss]

Currently this works in the backup view for containers/VMs, but not in
the storage backup view. Implement that for the latter part too.

Uses the callback functionality of the load() method of the store to
properly update the UI as soon as loading is finished.
While at it, clean up the same thing in grid/BackupView.js to remove the
current hack.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 FWIW, using me.store.load({..}) directly in grid/BackupView.js works
 perfectly fine too (as I would expect). But I reused reload() for now,
 to keep consistency with the rest of the file. Thus the added `args`.

 www/manager6/grid/BackupView.js    | 16 +++++++---------
 www/manager6/storage/BackupView.js |  6 +++++-
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index 7f7e1b62..dda8a363 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -79,9 +79,9 @@ Ext.define('PVE.grid.BackupView', {
 	    ]);
 	};

-	var reload = Ext.Function.createBuffered(function() {
+	var reload = Ext.Function.createBuffered(function(args) {
 	    if (me.store) {
-		me.store.load();
+		me.store.load(args);
 	    }
 	}, 100);

@@ -300,20 +300,18 @@ Ext.define('PVE.grid.BackupView', {
 			handler: function(button, event, record) {
 			    let volid = record.data.volid, storage = storagesel.getValue();
 			    let url = `/api2/extjs/nodes/${nodename}/storage/${storage}/content/${volid}`;
-			    let newProtection = record.data.protected ? 0 : 1;
 			    Proxmox.Utils.API2Request({
 				url: url,
 				method: 'PUT',
 				waitMsgTarget: me,
 				params: {
-				    'protected': newProtection,
+				    'protected': record.data.protected ? 0 : 1,
 				},
 				failure: (response) => Ext.Msg.alert('Error', response.htmlStatus),
-				success: (response) => {
-				    reload();
-				    // propagate to remove button, fake for event as reload is to slow
-				    record.data.protected = newProtection; // TODO: check if writing is OK!
-				    sm.fireEvent('selectionchange', sm, [record]);
+				success: () => {
+				    reload({
+					callback: () => sm.fireEvent('selectionchange', sm, [record]),
+				    });
 				},
 			    });
 			},
diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
index b8dc8f11..fbdf573d 100644
--- a/www/manager6/storage/BackupView.js
+++ b/www/manager6/storage/BackupView.js
@@ -183,7 +183,11 @@ Ext.define('PVE.storage.BackupView', {
 			waitMsgTarget: me,
 			params: { 'protected': record.data.protected ? 0 : 1 },
 			failure: response => Ext.Msg.alert('Error', response.htmlStatus),
-			success: () => me.store.load(),
+			success: () => {
+			    me.store.load({
+				callback: () => sm.fireEvent('selectionchange', sm, [record]),
+			    });
+			},
 		    });
 		},
 	    },
--
2.34.1

Re: [pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change

[Thomas Lamprecht]

Looks ok (but did not tested it yet), few small nits inline

Am 18/01/2023 um 14:01 schrieb Christoph Heiss:
> Currently this works in the backup view for containers/VMs, but not in
> the storage backup view. Implement that for the latter part too.
> 
> Uses the callback functionality of the load() method of the store to
> properly update the UI as soon as loading is finished.
> While at it, clean up the same thing in grid/BackupView.js to remove the

replace file name with (parts of) the module name or xtype.

> current hack.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  FWIW, using me.store.load({..}) directly in grid/BackupView.js works
>  perfectly fine too (as I would expect). But I reused reload() for now,
>  to keep consistency with the rest of the file. Thus the added `args`.
> 
>  www/manager6/grid/BackupView.js    | 16 +++++++---------
>  www/manager6/storage/BackupView.js |  6 +++++-
>  2 files changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
> index 7f7e1b62..dda8a363 100644
> --- a/www/manager6/grid/BackupView.js
> +++ b/www/manager6/grid/BackupView.js
> @@ -79,9 +79,9 @@ Ext.define('PVE.grid.BackupView', {
>  	    ]);
>  	};
> 
> -	var reload = Ext.Function.createBuffered(function() {
> +	var reload = Ext.Function.createBuffered(function(args) {

two nits:

- please transform to `let` or `const` when touching anyway
- s/args/options/ to be more in line with ExtJS terminology [0] for this parameter
  as otherwise it somewhat suggests one could pass arbitrary `arguments`.

[0]: https://docs.sencha.com/extjs/7.0.0/classic/Ext.data.Store.html#method-load

>  	    if (me.store) {
> -		me.store.load();
> +		me.store.load(args);
>  	    }
>  	}, 100);
>