From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64
Date: Tue, 17 Jan 2023 13:17:22 +0100 [thread overview]
Message-ID: <20230117121723.65246-1-m.heiserer@proxmox.com> (raw)
Sets the EFI version to 2m when arch=aarch64.
When the VM has arch=aarch64, creating an EFI disk failed with
"Can't use an undefined value as an ARRAY reference at /usr/share/perl5/PVE/QemuServer.pm line 3382. (500)"
That's because we only have EFI 2m available for aarch64.
Reported in the forum: https://forum.proxmox.com/threads/121160/
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
www/manager6/qemu/HDEfi.js | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/HDEfi.js b/www/manager6/qemu/HDEfi.js
index a8ca8f56..ef3092a6 100644
--- a/www/manager6/qemu/HDEfi.js
+++ b/www/manager6/qemu/HDEfi.js
@@ -26,7 +26,7 @@ Ext.define('PVE.qemu.EFIDiskInputPanel', {
// always default to newer 4m type with secure boot support, if we're
// adding a new EFI disk there can't be any old state anyway
- me.drive.efitype = '4m';
+ me.drive.efitype = me.config.useOldVersion ? '2m' : '4m';
me.drive['pre-enrolled-keys'] = values.preEnrolledKeys;
delete values.preEnrolledKeys;
@@ -103,15 +103,24 @@ Ext.define('PVE.qemu.EFIDiskEdit', {
throw "no node name specified";
}
- me.items = [{
+ const efiInputPanel = Ext.create({
xtype: 'pveEFIDiskInputPanel',
onlineHelp: 'qm_bios_and_uefi',
confid: me.confid,
nodename: nodename,
usesEFI: me.usesEFI,
isCreate: true,
- }];
+ useOldVersion: false,
+ });
+ me.items = [efiInputPanel];
me.callParent();
+
+ me.load({
+ success: function(response) {
+ const data = response.result.data;
+ efiInputPanel.config.useOldVersion = data.arch === 'aarch64';
+ },
+ });
},
});
--
2.30.2
next reply other threads:[~2023-01-17 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 12:17 Matthias Heiserer [this message]
2023-01-17 12:17 ` [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const Matthias Heiserer
2023-01-18 14:03 ` Thomas Lamprecht
2023-01-20 11:16 ` Matthias Heiserer
2023-01-20 13:59 ` Thomas Lamprecht
2023-01-18 14:07 ` [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64 Thomas Lamprecht
2023-01-20 12:56 ` Matthias Heiserer
2023-01-20 13:17 ` Thomas Lamprecht
2023-01-20 14:18 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117121723.65246-1-m.heiserer@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox