From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories
Date: Thu, 5 Jan 2023 15:02:29 +0100 [thread overview]
Message-ID: <20230105140229.wfhfyucnde4olytq@casey.proxmox.com> (raw)
In-Reply-To: <fb1d7660-8c05-1a67-d353-ba8ccc566636@proxmox.com>
On Thu, Jan 05, 2023 at 02:53:41PM +0100, Thomas Lamprecht wrote:
> Am 05/01/2023 um 14:41 schrieb Wolfgang Bumiller:
> > Actually, I just realized that these are actually *relative* paths
>
> yeah that's the idea, relative paths from the storage MP.
>
> > written "as absolute" paths, and if not, the error will now actually say
> > that it is not an absolute path as well.
>
> cosmetic, but yeah. What I rather find odd is the separation format, why
> don't we use the quoted string format that the maintenance stuff in PBS
> added?
We just had a short off-list discussion about the formatting and will
also switch it to `=` instead of `:` to separate the vtype from the path
so it works more like a property string (since we don't usually use
`key:value` and it would also in theory allow switching to an actual
object/property-string based schema later on).
As for quoting, do we have this in PVE yet?
But I don't very much mind not being able to use any of ';', '=' or ','
for paths for the initial implementation.
prev parent reply other threads:[~2023-01-05 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:04 Leo Nunner
2023-01-02 16:04 ` [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations Leo Nunner
2023-01-05 13:34 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:54 ` [pve-devel] " Thomas Lamprecht
2023-01-02 16:04 ` [pve-devel] [PATCH v2 docs] docs: document 'dirs' parameter for directory storage Leo Nunner
2023-01-05 13:35 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:41 ` [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories Wolfgang Bumiller
2023-01-05 13:53 ` Thomas Lamprecht
2023-01-05 14:02 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105140229.wfhfyucnde4olytq@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox