From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Leo Nunner <l.nunner@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories
Date: Thu, 5 Jan 2023 14:41:48 +0100 [thread overview]
Message-ID: <20230105134148.34ugmaorbb75eurj@casey.proxmox.com> (raw)
In-Reply-To: <20230102160438.180285-1-l.nunner@proxmox.com>
Actually, I just realized that these are actually *relative* paths
written "as absolute" paths, and if not, the error will now actually say
that it is not an absolute path as well.
Also the docs say absolute paths, but they are not.
So please add a followup which drops the use of `verify_path` (rather,
just allow all values or perhaps forbid it containing '..' (without even
bothering checking for slashes around).
next prev parent reply other threads:[~2023-01-05 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:04 Leo Nunner
2023-01-02 16:04 ` [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations Leo Nunner
2023-01-05 13:34 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:54 ` [pve-devel] " Thomas Lamprecht
2023-01-02 16:04 ` [pve-devel] [PATCH v2 docs] docs: document 'dirs' parameter for directory storage Leo Nunner
2023-01-05 13:35 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:41 ` Wolfgang Bumiller [this message]
2023-01-05 13:53 ` [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories Thomas Lamprecht
2023-01-05 14:02 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230105134148.34ugmaorbb75eurj@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox