[pve-devel] [PATCH common/qemu-server/manager v4] fix #3502: VM start timeout config parameter

[Daniel Tschlatscher <d.tschlatscher@proxmox.com>]

This patch series adds a an option to specify a timeout value in the
config for starting VMs.
The minimum is 0 seconds, which disables the timeout completely. The
maximum is 86400 seconds, equivalent to 1 day.

The timeout value can also be passed via the CLI, which always
overrides the setting. If no value for timeout is passed, the timeout
will either be read from the config, or if unavailable, chosen
heuristically like before, with a default of 30 seconds in most cases.

For this, a new property string called "startoptions" is added.
Currently only the VM start timeout is configurable with it.


Changes from v3
* Minor code cleanup
* Addressed an edge case concerning the killing of a lingering VM to
  not accidentally kill an unrelated process

Thanks to Fabian for the review and suggestions!


pve-common:

Daniel Tschlatscher (1):
  VM start timeout config parameter

 src/PVE/JSONSchema.pm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

qemu-server:

Daniel Tschlatscher (4):
  expose VM start timeout config setting in API
  await and kill lingering KVM thread when VM start reaches timeout
  re-check if VM is running and PID for KILL after timeout
  make the timeout value editable when the VM is locked

 PVE/API2/Qemu.pm          | 27 ++++++++++++++++++++++++++
 PVE/QemuServer.pm         | 41 +++++++++++++++++++++++++++++++--------
 PVE/QemuServer/Helpers.pm |  4 ++++
 3 files changed, 64 insertions(+), 8 deletions(-)

pve-manager:

Daniel Tschlatscher (1):
  VM start Timeout "Options" parameter in the GUI

 www/manager6/qemu/Options.js | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

-- 
2.30.2