From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit v6 3/3] add task log download button in TaskViewer
Date: Wed, 4 Jan 2023 13:56:35 +0100 [thread overview]
Message-ID: <20230104125635.421634-4-d.tschlatscher@proxmox.com> (raw)
In-Reply-To: <20230104125635.421634-1-d.tschlatscher@proxmox.com>
Adds a download button in the TaskViewer. Uses the newly created
downloadAsFile() method in the Utils class.
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
Changes from v5
* Last version erroneously used "limit=0" instead of the download
parameter in the download URL
src/window/TaskViewer.js | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/window/TaskViewer.js b/src/window/TaskViewer.js
index 5d8bb84..3d8ea00 100644
--- a/src/window/TaskViewer.js
+++ b/src/window/TaskViewer.js
@@ -230,11 +230,23 @@ Ext.define('Proxmox.window.TaskViewer', {
border: false,
});
+ let downloadBtn = new Ext.Button({
+ text: gettext('Download'),
+ iconCls: 'fa fa-download',
+ handler: function() {
+ let url = '/api2/extjs/nodes/' +
+ `${task.node}/tasks/${encodeURIComponent(me.upid)}/log?download=1`;
+
+ Proxmox.Utils.downloadAsFile(url);
+ },
+ });
+
+
let logView = Ext.create('Proxmox.panel.LogView', {
title: gettext('Output'),
- tbar: [stop_btn2],
+ tbar: [stop_btn2, '->', downloadBtn],
border: false,
- url: "/api2/extjs/nodes/" + task.node + "/tasks/" + encodeURIComponent(me.upid) + "/log",
+ url: `/api2/extjs/nodes/${task.node}/tasks/${encodeURIComponent(me.upid)}/log`,
});
me.mon(statstore, 'load', function() {
@@ -249,6 +261,7 @@ Ext.define('Proxmox.window.TaskViewer', {
stop_btn1.setDisabled(status !== 'running');
stop_btn2.setDisabled(status !== 'running');
+ downloadBtn.setDisabled(status === 'running');
});
statstore.startUpdate();
--
2.30.2
next prev parent reply other threads:[~2023-01-04 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 12:56 [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button Daniel Tschlatscher
2023-01-04 12:56 ` [pve-devel] [PATCH manager v6 1/3] make task log downloadable in the PVE manager backend Daniel Tschlatscher
2023-01-04 12:56 ` [pve-devel] [PATCH widget-toolkit v6 2/3] Source file download in new Utils function Daniel Tschlatscher
2023-01-04 12:56 ` Daniel Tschlatscher [this message]
2023-01-04 13:31 ` [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button Stefan Sterz
2023-01-04 13:46 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104125635.421634-4-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox