From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive
Date: Tue, 20 Dec 2022 11:30:36 +0100 [thread overview]
Message-ID: <20221220103037.890813-1-s.sterz@proxmox.com> (raw)
when a vm is configured to use a physical cd rom drive but there is no
such drive a cryptic "uninitialized value" error is thrown. this is
due to `$path` being undefined in `sub print_drive_commandline_full`.
warn that no cd rom drive is available instead.
note that the error was cosmetic as the vm would start just fine.
forum thread: https://forum.proxmox.com/threads/119592/
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
changes from v3 (thanks @ Thomas Lamprecht):
* use `log_warn` instead of `warn`
* dont return results of assignments
changes from v2 (thanks @ Fiona Ebner):
* added newline to message
* cache the fact that no drive is available so we warn only once
* adjusted error message again
changes from v1:
* make the error message more concise.
* use shorter forum link for better formatting in commit message
(thanks @ Fiona Ebner).
PVE/QemuServer.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 39fc6b0..3837bd9 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1287,11 +1287,16 @@ sub option_exists {
my $cdrom_path;
sub get_cdrom_path {
- return $cdrom_path if $cdrom_path;
+ return $cdrom_path if defined($cdrom_path);
return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom";
return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1";
return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2";
+
+ log_warn("no physical CD-ROM available, ignoring");
+ $cdrom_path = '';
+
+ return $cdrom_path;
}
sub get_iso_path {
--
2.30.2
next reply other threads:[~2022-12-20 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 10:30 Stefan Sterz [this message]
2022-12-20 10:30 ` [pve-devel] [PATCH qemu-server v4 2/2] cd rom handling: refactor cd rom path helper function Stefan Sterz
2023-01-13 12:53 ` [pve-devel] applied: [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220103037.890813-1-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox