public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again
@ 2022-12-20  8:19 Fiona Ebner
  2022-12-20  8:19 ` [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency Fiona Ebner
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fiona Ebner @ 2022-12-20  8:19 UTC (permalink / raw)
  To: pve-devel

Commit d03e1b3 ("update submodule and patches to 7.2.0") argued that
slirp is not explicitly supported in PVE, but that is not true. In
qemu-server, user networking is supported (via CLI/API) when no bridge
is set on a virtual NIC. So slirp needs to stay to keep such NICs
working.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 89c234a..6d5f882 100755
--- a/debian/rules
+++ b/debian/rules
@@ -62,7 +62,6 @@ ${BUILDDIR}/config.status: configure
 	--disable-smartcard \
 	--disable-strip \
 	--disable-xen \
-	--disable-slirp \
 	--enable-curl \
 	--enable-docs \
 	--enable-glusterfs \
@@ -75,6 +74,7 @@ ${BUILDDIR}/config.status: configure
 	--enable-opengl \
 	--enable-rbd \
 	--enable-seccomp \
+	--enable-slirp \
 	--enable-spice \
 	--enable-usb-redir \
 	--enable-virglrenderer \
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency
  2022-12-20  8:19 [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again Fiona Ebner
@ 2022-12-20  8:19 ` Fiona Ebner
  2022-12-20  8:19 ` [pve-devel] [PATCH qemu 3/3] d/control: drop outdated jemalloc dependencies Fiona Ebner
  2022-12-21 13:14 ` [pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2022-12-20  8:19 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/control b/debian/control
index 45e9ab9..c051152 100644
--- a/debian/control
+++ b/debian/control
@@ -26,6 +26,7 @@ Build-Depends: autotools-dev,
                librbd-dev (>= 0.48),
                libsdl1.2-dev,
                libseccomp-dev,
+               libslirp-dev,
                libspice-protocol-dev (>= 0.12.14~),
                libspice-server-dev (>= 0.14.0~),
                libsystemd-dev,
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH qemu 3/3] d/control: drop outdated jemalloc dependencies
  2022-12-20  8:19 [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again Fiona Ebner
  2022-12-20  8:19 ` [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency Fiona Ebner
@ 2022-12-20  8:19 ` Fiona Ebner
  2022-12-21 13:14 ` [pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2022-12-20  8:19 UTC (permalink / raw)
  To: pve-devel

Commit 3d785ea ("disable jemalloc") disabled jemalloc support, so
these are not needed anymore.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/control | 2 --
 1 file changed, 2 deletions(-)

diff --git a/debian/control b/debian/control
index c051152..4898e9b 100644
--- a/debian/control
+++ b/debian/control
@@ -16,7 +16,6 @@ Build-Depends: autotools-dev,
                libglusterfs-dev (>= 5.2-2),
                libgnutls28-dev,
                libiscsi-dev (>= 1.12.0),
-               libjemalloc-dev,
                libjpeg-dev,
                libjson-perl,
                libnuma-dev,
@@ -58,7 +57,6 @@ Depends: ceph-common (>= 0.48),
          libglusterfs-dev | glusterfs-common (>= 5.6),
          libglusterfs0 | glusterfs-common (>= 5.6),
          libiscsi4 (>= 1.12.0) | libiscsi7,
-         libjemalloc2,
          libjpeg62-turbo,
          libspice-server1 (>= 0.14.0~),
          libusb-1.0-0 (>= 1.0.17-1),
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again
  2022-12-20  8:19 [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again Fiona Ebner
  2022-12-20  8:19 ` [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency Fiona Ebner
  2022-12-20  8:19 ` [pve-devel] [PATCH qemu 3/3] d/control: drop outdated jemalloc dependencies Fiona Ebner
@ 2022-12-21 13:14 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2022-12-21 13:14 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

On 20/12/2022 09:19, Fiona Ebner wrote:
> Commit d03e1b3 ("update submodule and patches to 7.2.0") argued that
> slirp is not explicitly supported in PVE, but that is not true. In
> qemu-server, user networking is supported (via CLI/API) when no bridge
> is set on a virtual NIC. So slirp needs to stay to keep such NICs
> working.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  debian/rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-21 13:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-20  8:19 [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again Fiona Ebner
2022-12-20  8:19 ` [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency Fiona Ebner
2022-12-20  8:19 ` [pve-devel] [PATCH qemu 3/3] d/control: drop outdated jemalloc dependencies Fiona Ebner
2022-12-21 13:14 ` [pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal