public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu 1/3] d/rules: enable slirp again
Date: Tue, 20 Dec 2022 09:19:51 +0100	[thread overview]
Message-ID: <20221220081953.59174-1-f.ebner@proxmox.com> (raw)

Commit d03e1b3 ("update submodule and patches to 7.2.0") argued that
slirp is not explicitly supported in PVE, but that is not true. In
qemu-server, user networking is supported (via CLI/API) when no bridge
is set on a virtual NIC. So slirp needs to stay to keep such NICs
working.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 89c234a..6d5f882 100755
--- a/debian/rules
+++ b/debian/rules
@@ -62,7 +62,6 @@ ${BUILDDIR}/config.status: configure
 	--disable-smartcard \
 	--disable-strip \
 	--disable-xen \
-	--disable-slirp \
 	--enable-curl \
 	--enable-docs \
 	--enable-glusterfs \
@@ -75,6 +74,7 @@ ${BUILDDIR}/config.status: configure
 	--enable-opengl \
 	--enable-rbd \
 	--enable-seccomp \
+	--enable-slirp \
 	--enable-spice \
 	--enable-usb-redir \
 	--enable-virglrenderer \
-- 
2.30.2





             reply	other threads:[~2022-12-20  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  8:19 Fiona Ebner [this message]
2022-12-20  8:19 ` [pve-devel] [PATCH qemu 2/3] d/control: add libslirp-dev as a build dependency Fiona Ebner
2022-12-20  8:19 ` [pve-devel] [PATCH qemu 3/3] d/control: drop outdated jemalloc dependencies Fiona Ebner
2022-12-21 13:14 ` [pve-devel] applied-series: Re: [PATCH qemu 1/3] d/rules: enable slirp again Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220081953.59174-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal