From: Noel Ullreich <n.ullreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/2] catch missing ovmf file
Date: Tue, 6 Dec 2022 14:11:38 +0100 [thread overview]
Message-ID: <20221206131138.221400-3-n.ullreich@proxmox.com> (raw)
In-Reply-To: <20221206131138.221400-1-n.ullreich@proxmox.com>
check to see if the OVMF_VARS file actually exists. otherwise lines
3666 and 3673 break and give a cryptic error message
Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
---
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 2a2f1f7..38f3145 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3640,6 +3640,7 @@ sub config_to_command {
my ($ovmf_code, $ovmf_vars) = get_ovmf_files($arch, $d, $q35);
die "EFI base image '$ovmf_code' not found\n" if ! -f $ovmf_code;
+ die "EFI vars image '$ovmf_vars' not found\n" if ! -f $ovmf_vars;
my ($path, $format);
my $read_only_str = '';
--
2.30.2
next prev parent reply other threads:[~2022-12-06 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 13:11 [pve-devel] [PATCH qemu-server 0/2] fix #4378: standardized error for ovmf files Noel Ullreich
2022-12-06 13:11 ` [pve-devel] [PATCH qemu-server 1/2] " Noel Ullreich
2022-12-06 13:11 ` Noel Ullreich [this message]
2022-12-06 15:55 ` [pve-devel] [PATCH qemu-server 2/2] catch missing ovmf file Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206131138.221400-3-n.ullreich@proxmox.com \
--to=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox