From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit v5 2/3] Source file download in new Utils function
Date: Thu, 1 Dec 2022 13:50:13 +0100 [thread overview]
Message-ID: <20221201125014.359413-3-d.tschlatscher@proxmox.com> (raw)
In-Reply-To: <20221201125014.359413-1-d.tschlatscher@proxmox.com>
Adds a function for downloading a file from a remote URL in the Utils
class and uses it to revise one similar usage in FileBrowser.js
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
No changes from v4 (was last included in v2)
src/Utils.js | 13 +++++++++++++
src/window/FileBrowser.js | 11 +++++------
2 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index 7255e3f..ef0c2b8 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -1360,6 +1360,19 @@ utilities: {
}
return `<span class="${cls}" style="${style}">${string}</span>`;
},
+
+ // Setting filename here when downloading from a remote url sometimes fails in chromium browsers
+ // because of a bug when using attribute download in conjunction with a self signed certificate.
+ // For more info see https://bugs.chromium.org/p/chromium/issues/detail?id=993362
+ downloadAsFile: function(source, fileName) {
+ let hiddenElement = document.createElement('a');
+ hiddenElement.href = source;
+ hiddenElement.target = '_blank';
+ if (fileName) {
+ hiddenElement.download = fileName;
+ }
+ hiddenElement.click();
+ },
},
singleton: true,
diff --git a/src/window/FileBrowser.js b/src/window/FileBrowser.js
index a519d6b..4e4c639 100644
--- a/src/window/FileBrowser.js
+++ b/src/window/FileBrowser.js
@@ -101,18 +101,17 @@ Ext.define("Proxmox.window.FileBrowser", {
let params = { ...view.extraParams };
params.filepath = data.filepath;
- let atag = document.createElement('a');
- atag.download = view.downloadPrefix + data.text;
+ let filename = view.downloadPrefix + data.text;
if (data.type === 'd') {
if (tar) {
params.tar = 1;
- atag.download += ".tar.zst";
+ filename += ".tar.zst";
} else {
- atag.download += ".zip";
+ filename += ".zip";
}
}
- atag.href = me.buildUrl(view.downloadURL, params);
- atag.click();
+
+ Proxmox.Utils.downloadAsFile(me.buildUrl(view.downloadURL, params), filename);
},
fileChanged: function() {
--
2.30.2
next prev parent reply other threads:[~2022-12-01 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 12:50 [pve-devel] [PATCH manager/widget-toolkit v5] fix: #3971 Tasklog download button Daniel Tschlatscher
2022-12-01 12:50 ` [pve-devel] [PATCH manager v5 1/3] make task log downloadable in the PVE manager backend Daniel Tschlatscher
2023-01-04 12:29 ` Stefan Sterz
2022-12-01 12:50 ` Daniel Tschlatscher [this message]
2022-12-01 12:50 ` [pve-devel] [PATCH widget-toolkit v5 3/3] add task log download button in TaskViewer Daniel Tschlatscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201125014.359413-3-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox