From: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH SERIES V4 pve-container/qemu-server/pve-manager 0/7] fix #3711 & adapt drive detach/remove behavior
Date: Fri, 25 Nov 2022 15:40:01 +0100 [thread overview]
Message-ID: <20221125144008.2988072-1-s.hrdlicka@proxmox.com> (raw)
V3 -> V4:
# pve-container
* add check for linked clones to avoid partially deleting volumes
# pve-container
* remove ignore_storage_errors
* ignores now errors with PVE::Storage::path
# pve-manager
* remove checkbox ignore errors checkbox from VM delete
V2 -> V3:
# pve-storage
* change removed
# pve-container
* remove storage_exists
* reduce code lines used
# qemu-server
* reduce code lines used
# pve-manager
* no change
V1 -> V2:
# overall
* matched detaching/removing drives behavior for VM & containers
It currently works this way:
- Detach drive
- drive shows up as unused
- remove drive
- drive will be removed without removing data (obviously)
# pve-storage
* added storage_exists function for matching detach/remove behavoir
# pve-container
* review fixes:
* variable naming
* desciption string adapted
* moved eval further up the call chain
* removed ticket number form cleanup
* check if storage exists for unused disks
# qemu-server
* add same force option as for containers
* match detach/remove behavoir between VM/container
* shorten line
# pve-manager
* added same option for VMs as for containers
Stefan Hrdlicka (4):
fix #3711: optionally allow CT deletion to complete on disk volume
removal errors
adapt behavior for detaching/removing a mount point
add linked clone check for LXC container template deletion
cleanup: remove spaces from empty lines
src/PVE/API2/LXC.pm | 8 ++++++++
src/PVE/LXC.pm | 28 +++++++++++++++++++++-------
src/PVE/LXC/Config.pm | 6 +++++-
3 files changed, 34 insertions(+), 8 deletions(-)
--
2.30.2
next reply other threads:[~2022-11-25 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:40 Stefan Hrdlicka [this message]
2022-11-25 14:40 ` [pve-devel] [PATCH V4 pve-container 1/7] fix #3711: optionally allow CT deletion to complete on disk volume removal errors Stefan Hrdlicka
2022-12-13 13:07 ` Fiona Ebner
2022-11-25 14:40 ` [pve-devel] [PATCH V4 pve-container 2/7] adapt behavior for detaching/removing a mount point Stefan Hrdlicka
2022-12-13 13:08 ` Fiona Ebner
2022-11-25 14:40 ` [pve-devel] [PATCH V4 pve-container 3/7] add linked clone check for LXC container template deletion Stefan Hrdlicka
2022-12-13 13:08 ` Fiona Ebner
2022-11-25 14:40 ` [pve-devel] [PATCH V4 pve-container 4/7] cleanup: remove spaces from empty lines Stefan Hrdlicka
2022-11-25 14:40 ` [pve-devel] [PATCH V4 qemu-server 5/7] ignore PVE::Storage::path errors when deleting VMs Stefan Hrdlicka
2022-12-13 13:08 ` Fiona Ebner
2022-11-25 14:40 ` [pve-devel] [PATCH V4 qemu-server 6/7] adapt behavior for detaching drives to deatching container mount points Stefan Hrdlicka
2022-12-13 13:08 ` Fiona Ebner
2022-11-25 14:40 ` [pve-devel] [PATCH V4 pve-manager 7/7] fix #3711: optionally allow CT deletion to complete on disk volume removal errors Stefan Hrdlicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125144008.2988072-1-s.hrdlicka@proxmox.com \
--to=s.hrdlicka@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox