* [pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config
@ 2022-11-21 14:39 Dominik Csapak
2022-11-21 14:57 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-11-21 14:39 UTC (permalink / raw)
To: pve-devel
to have a iothread on by default in the wizard and on disk add, we
added a 'bind' for the value here. This also changes the value
for existing vm disks, and if one does not notice, modifies it
away again (since we don't have the controller here and isSCSISingle is
false)
simply don't bind value when we edit a vm disk from config
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/qemu/HDEdit.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 921bfe72d..b78647ec8 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -255,10 +255,12 @@ Ext.define('PVE.qemu.HDInputPanel', {
name: 'iothread',
fieldLabel: 'IO thread',
clearOnDisable: true,
- bind: {
+ bind: me.insideWizard || me.isCreate ? {
disabled: '{!isVirtIO && !isSCSI}',
// Checkbox.setValue handles Arrays in a different way, therefore cast to bool
value: '{!!isVirtIO || (isSCSI && isSCSISingle)}',
+ } : {
+ disabled: '{!isVirtIO && !isSCSI}',
},
},
);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH manager] ui: qemu disk: honor iothread setting from config
2022-11-21 14:39 [pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config Dominik Csapak
@ 2022-11-21 14:57 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-21 14:57 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 21/11/2022 um 15:39 schrieb Dominik Csapak:
> to have a iothread on by default in the wizard and on disk add, we
> added a 'bind' for the value here. This also changes the value
> for existing vm disks, and if one does not notice, modifies it
> away again (since we don't have the controller here and isSCSISingle is
> false)
>
> simply don't bind value when we edit a vm disk from config
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/qemu/HDEdit.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks! for the record: this wasn't an issue in Firefox.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-21 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 14:39 [pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config Dominik Csapak
2022-11-21 14:57 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox