public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config
Date: Mon, 21 Nov 2022 15:39:06 +0100	[thread overview]
Message-ID: <20221121143906.195079-1-d.csapak@proxmox.com> (raw)

to have a iothread on by default in the wizard and on disk add, we
added a 'bind' for the value here. This also changes the value
for existing vm disks, and if one does not notice, modifies it
away again (since we don't have the controller here and isSCSISingle is
false)

simply don't bind value when we edit a vm disk from config

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 921bfe72d..b78647ec8 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -255,10 +255,12 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		name: 'iothread',
 		fieldLabel: 'IO thread',
 		clearOnDisable: true,
-		bind: {
+		bind: me.insideWizard || me.isCreate ? {
 		    disabled: '{!isVirtIO && !isSCSI}',
 		    // Checkbox.setValue handles Arrays in a different way, therefore cast to bool
 		    value: '{!!isVirtIO || (isSCSI && isSCSISingle)}',
+		} : {
+		    disabled: '{!isVirtIO && !isSCSI}',
 		},
 	    },
 	);
-- 
2.30.2





             reply	other threads:[~2022-11-21 14:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 14:39 Dominik Csapak [this message]
2022-11-21 14:57 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221121143906.195079-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal