[pve-devel] [PATCH widget-toolkit 1/2] css: don't make full tags inline-block in the tree

[pve-devel] [PATCH widget-toolkit 1/2] css: don't make full tags inline-block in the tree

[Dominik Csapak]

when showing full tags in the tree as inline-block, the height is increased,
leading to unwanted 'wobble' when tags are added/removed

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/css/ext6-pmx.css | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
index 37cadde..b9bfb35 100644
--- a/src/css/ext6-pmx.css
+++ b/src/css/ext6-pmx.css
@@ -14,6 +14,11 @@
     display: inline-block;
 }
 
+.proxmox-tags-full .x-grid-cell-inner-treecolumn .proxmox-tag-light,
+.proxmox-tags-full .x-grid-cell-inner-treecolumn .proxmox-tag-dark {
+    display: inherit;
+}
+
 .x-boundlist-item > .proxmox-tag-light,
 .x-boundlist-item > .proxmox-tag-dark {
     line-height: 15px;
-- 
2.30.2

[pve-devel] [PATCH widget-toolkit 2/2] log/journal view: fix acces to me after destroying

[Dominik Csapak]

it can happen that the view is destroyed during an api call,
so we should check if it's destroyed as the first thing in the
callback

if the view is destroyed, there is nothing we can do here, so simply
return

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/panel/JournalView.js | 3 +++
 src/panel/LogView.js     | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js
index f3af36b..32c005a 100644
--- a/src/panel/JournalView.js
+++ b/src/panel/JournalView.js
@@ -143,6 +143,9 @@ Ext.define('Proxmox.panel.JournalView', {
 		waitMsgTarget: !livemode ? view : undefined,
 		method: 'GET',
 		success: function(response) {
+		    if (me.isDestroyed) {
+			return;
+		    }
 		    Proxmox.Utils.setErrorMask(me, false);
 		    let lines = response.result.data;
 		    me.updateView(lines, livemode, top);
diff --git a/src/panel/LogView.js b/src/panel/LogView.js
index dcbd002..44aa8e3 100644
--- a/src/panel/LogView.js
+++ b/src/panel/LogView.js
@@ -98,6 +98,9 @@ Ext.define('Proxmox.panel.LogView', {
 		params: viewModel.get('params'),
 		method: 'GET',
 		success: function(response) {
+		    if (me.isDestroyed) {
+			return;
+		    }
 		    Proxmox.Utils.setErrorMask(me, false);
 		    let total = response.result.total;
 		    let lines = [];
-- 
2.30.2

Re: [pve-devel] [PATCH widget-toolkit 2/2] log/journal view: fix acces to me after destroying

[Dominik Csapak]

argh... typo in subject:

s/acces/access/

[pve-devel] applied: [PATCH widget-toolkit 1/2] css: don't make full tags inline-block in the tree

[Thomas Lamprecht]

Am 21/11/2022 um 08:53 schrieb Dominik Csapak:
> when showing full tags in the tree as inline-block, the height is increased,
> leading to unwanted 'wobble' when tags are added/removed
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/css/ext6-pmx.css | 5 +++++
>  1 file changed, 5 insertions(+)
> 
>

applied with typo in the subject of patch 2/2 fixed, thanks!