public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] NetworkEdit: Use default model
@ 2022-11-18 10:29 Matthias Heiserer
  2022-11-18 11:57 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Heiserer @ 2022-11-18 10:29 UTC (permalink / raw)
  To: pve-devel

Patch eb1a09647d25d6d588260a971187a8803453a9ed broke the preselected
Model by setting it to ''. The GUI displays/selects an empty field
as default.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/qemu/NetworkEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index 9e90a4e2..d85fbfac 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -36,7 +36,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 
     viewModel: {
 	data: {
-	    networkModel: '',
+	    networkModel: undefined,
 	    mtu: '',
 	},
 	formulas: {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] NetworkEdit: Use default model
  2022-11-18 10:29 [pve-devel] [PATCH manager] NetworkEdit: Use default model Matthias Heiserer
@ 2022-11-18 11:57 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-18 11:57 UTC (permalink / raw)
  To: Proxmox VE development discussion, Matthias Heiserer

Am 18/11/2022 um 11:29 schrieb Matthias Heiserer:
> Patch eb1a09647d25d6d588260a971187a8803453a9ed broke the preselected
> Model by setting it to ''. The GUI displays/selects an empty field
> as default.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  www/manager6/qemu/NetworkEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, with subject fixed to "ui: vm network edit: use the correct default model",
thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-18 11:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 10:29 [pve-devel] [PATCH manager] NetworkEdit: Use default model Matthias Heiserer
2022-11-18 11:57 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal