public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers
@ 2022-11-18  1:39 John Hollowell
  2022-11-18  1:39 ` [pve-devel] [PATCH v2 http-server 1/2] fix #4344: http-server: " John Hollowell
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: John Hollowell @ 2022-11-18  1:39 UTC (permalink / raw)
  To: pve-devel; +Cc: John Hollowell

This fixes an issue where an upload request without a Content-Type in
the file's multipart part would prevent the upload and throw
missleading errors. This patch removes the requirement and ignores
all multipart headers once the needed information has been extracted.

I have tested these changes against a 7.2-11 server and both a previously
broken upload method (without the Content-Type) and using the webUI in
Chrome (which includes a Content-Type) correctly uploads the file.

Changes since v1:
* remove `xx` and escaping of spaces from regex

John Hollowell (2):
  fix #4344: http-server: ignore unused multipart headers
  Remove whitespace ignore from regex

 src/PVE/APIServer/AnyEvent.pm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

--
2.30.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-06 13:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18  1:39 [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers John Hollowell
2022-11-18  1:39 ` [pve-devel] [PATCH v2 http-server 1/2] fix #4344: http-server: " John Hollowell
2022-11-18  1:39 ` [pve-devel] [PATCH v2 http-server 2/2] Remove whitespace ignore from regex John Hollowell
2022-11-18  9:47 ` [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers Matthias Heiserer
2023-03-06 13:16 ` [pve-devel] applied-series: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal