From: Leo Nunner <l.nunner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu-server manager docs] Properly check cloud-init drive permissions
Date: Wed, 16 Nov 2022 18:34:27 +0100 [thread overview]
Message-ID: <20221116173430.257506-1-l.nunner@proxmox.com> (raw)
The "Add CloudInit Drive" button in the UI was only enabled when the user
had Sys.Console permissions, even if the other correct permissions were
set. The backend check for these permissions also needed to be revamped
to be more consistent.
Changes from v1:
- Switch to purely checking for VM.Config.CDROM
(discussed offlist)
- Document VM.Config.Cloudinit in docs
- Whitespaces fixes
manager:
Leo Nunner (1):
fix #4321: properly check cloud-init drive permissions
www/manager6/qemu/HardwareView.js | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
qemu-server:
Leo Nunner (1):
fix #4321: properly check cloud-init drive permissions
PVE/API2/Qemu.pm | 6 ++++--
PVE/QemuServer/Drive.pm | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
docs:
Leo Nunner (1):
Document VM.Config.Cloudinit permission
pveum.adoc | 1 +
1 file changed, 1 insertion(+)
--
2.30.2
next reply other threads:[~2022-11-16 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 17:34 Leo Nunner [this message]
2022-11-16 17:34 ` [pve-devel] [PATCH v2 manager 1/1] fix #4321: properly " Leo Nunner
2022-11-17 8:23 ` Dominik Csapak
2022-11-16 17:34 ` [pve-devel] [PATCH v2 qemu-server " Leo Nunner
2022-11-17 7:15 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-16 17:34 ` [pve-devel] [PATCH docs 1/1] Document VM.Config.Cloudinit permission Leo Nunner
2022-11-17 7:10 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116173430.257506-1-l.nunner@proxmox.com \
--to=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox