From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: BackupEdit: fix reset tracking
Date: Tue, 15 Nov 2022 14:23:12 +0100 [thread overview]
Message-ID: <20221115132312.1270059-1-d.csapak@proxmox.com> (raw)
when the mode changes, we set the pool selector visible/hidden, but
we never disabled/enabled it. this tripped up the dirty state of the
form always showing the reset button as enabled.
to fix it, properly enable/disable it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/Backup.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index c81a76cea..4638cbb68 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -322,10 +322,12 @@ Ext.define('PVE.dc.BackupEdit', {
vmgrid.setDisabled(true);
vmidField.setValue('');
selPool.setVisible(true);
+ selPool.setDisabled(false);
selPool.allowBlank = false;
selectPoolMembers(selPool.value);
} else {
selPool.setVisible(false);
+ selPool.setDisabled(true);
selPool.allowBlank = true;
}
let list = vmidField.getValue();
--
2.30.2
next reply other threads:[~2022-11-15 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 13:23 Dominik Csapak [this message]
2022-11-15 13:32 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115132312.1270059-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox