public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/4] virtio-net: increase defaults rx|tx-queue-size to 1024
Date: Sun, 13 Nov 2022 15:37:36 +0100	[thread overview]
Message-ID: <20221113143738.878856-3-aderumier@odiso.com> (raw)
In-Reply-To: <20221113143738.878856-1-aderumier@odiso.com>

This is reducing packet drop on high pps, and also needed for dpdk.

Redhat already have use it by default in rhev and his openstack platform too
since 2019.

I'm using it in production since 6 months, I don't have seen performance regression.

fix: (which ask for custom option, but setting it by default seem fine for me)

https://bugzilla.proxmox.com/show_bug.cgi?id=1546
https://bugzilla.proxmox.com/show_bug.cgi?id=2349
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 PVE/QemuServer.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 2fed06d..e636c98 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1748,6 +1748,11 @@ sub print_netdevice_full {
 	    $tmpstr .= ",packed=on";
 	}
     }
+
+    if (min_version($machine_version, 7, 1) && $net->{model} eq 'virtio'){
+	$tmpstr .= ",rx_queue_size=1024,tx_queue_size=1024";
+    }
+
     $tmpstr .= ",bootindex=$net->{bootindex}" if $net->{bootindex} ;
 
     if (my $mtu = $net->{mtu}) {
-- 
2.30.2




  parent reply	other threads:[~2022-11-13 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 14:37 [pve-devel] [PATCH qemu-server 0/4] qemu 7.1: virtio-net: add new default values Alexandre Derumier
2022-11-13 14:37 ` [pve-devel] [PATCH qemu-server 1/4] fix #4296: virtio-net: enable packed queues for qemu 7.1 Alexandre Derumier
2022-11-13 14:37 ` Alexandre Derumier [this message]
2022-11-13 14:37 ` [pve-devel] [PATCH qemu-server 3/4] test: add qemu 7.1 default netdev rx|tx_queue_size=1024 Alexandre Derumier
2022-11-13 14:37 ` [pve-devel] [PATCH qemu-server 4/4] test: add qemu 7.1 multiqueue netdev test Alexandre Derumier
2022-11-13 15:49 ` [pve-devel] applied-series: [PATCH qemu-server 0/4] qemu 7.1: virtio-net: add new default values Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221113143738.878856-3-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal