From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices
Date: Wed, 9 Nov 2022 16:37:09 +0100 [thread overview]
Message-ID: <20221109153709.677876-1-d.tschlatscher@proxmox.com> (raw)
From: Oguz Bektas <o.bektas@proxmox.com>
we already have the 'mtu' option in the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Moved the message tooltip below the advanced columns to avoid the line
break and make it more visually pleasing.
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
Changes from v6
* The message tooltip is now in the advancedColumnB
www/manager6/qemu/NetworkEdit.js | 36 ++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..86067707 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
me.network.macaddr = values.macaddr;
me.network.disconnect = values.disconnect;
me.network.queues = values.queues;
+ me.network.mtu = values.mtu;
if (values.rate) {
me.network.rate = values.rate;
@@ -33,6 +34,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
return params;
},
+ viewModel: {
+ data: {
+ networkModel: '',
+ mtu: '',
+ },
+ formulas: {
+ isVirtio: get => get('networkModel') === 'virtio',
+ showMtuHint: get => get('mtu') === 1,
+ },
+ },
+
setNetwork: function(confid, data) {
var me = this;
@@ -93,6 +105,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
fieldLabel: gettext('Disconnect'),
name: 'disconnect',
},
+ {
+ xtype: 'proxmoxintegerfield',
+ name: 'mtu',
+ fieldLabel: 'MTU',
+ bind: {
+ disabled: '{!isVirtio}',
+ value: '{mtu}',
+ },
+ minValue: 1,
+ maxValue: 65520,
+ allowBlank: true,
+ },
];
if (me.insideWizard) {
@@ -112,6 +136,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
'macaddr',
'rate',
'queues',
+ 'mtu',
];
fields.forEach(function(fieldname) {
me.down('field[name='+fieldname+']').setDisabled(value);
@@ -130,6 +155,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
xtype: 'pveNetworkCardSelector',
name: 'model',
fieldLabel: gettext('Model'),
+ bind: '{networkModel}',
value: PVE.qemu.OSDefaults.generic.networkCard,
allowBlank: false,
},
@@ -162,6 +188,16 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
allowBlank: true,
},
];
+ me.advancedColumnB = [
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"),
+ bind: {
+ hidden: '{!showMtuHint}',
+ },
+ },
+ ];
me.callParent();
},
--
2.30.2
next reply other threads:[~2022-11-09 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 15:37 Daniel Tschlatscher [this message]
2022-11-16 18:58 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109153709.677876-1-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox