From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] gui: fix firewall security group help button chapter link
Date: Fri, 4 Nov 2022 10:18:47 +0100 [thread overview]
Message-ID: <20221104091847.60112-1-d.tschlatscher@proxmox.com> (raw)
The help button under Datacenter > Firewall > Security Group did not
have the proper help chapter link set.
First reported here:
https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
I noticed that the onlineHelp field for our custom classes is
sometimes defined outside of the class, in the Config which defines
the layout of the navigation panel, and sometimes inside of the class
directly.
This time I added it inside the class, as it seems to be the more
commonly used thing. Though, is there any preference for this?
www/manager6/dc/SecurityGroups.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/dc/SecurityGroups.js b/www/manager6/dc/SecurityGroups.js
index 5fb6860d..26172bf3 100644
--- a/www/manager6/dc/SecurityGroups.js
+++ b/www/manager6/dc/SecurityGroups.js
@@ -199,6 +199,7 @@ Ext.define('PVE.SecurityGroups', {
alias: 'widget.pveSecurityGroups',
title: 'Security Groups',
+ onlineHelp: 'pve_firewall_security_groups',
layout: 'border',
--
2.30.2
next reply other threads:[~2022-11-04 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 9:18 Daniel Tschlatscher [this message]
2022-11-04 9:56 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104091847.60112-1-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox