From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: {guest, node} summary: use correct unit for CPU usage
Date: Fri, 4 Nov 2022 08:42:55 +0100 [thread overview]
Message-ID: <20221104074255.8172-1-f.ebner@proxmox.com> (raw)
One could also think about showing something like '% of N CPUs', but
this can be inaccurate for older data, because the number of CPUs can
change.
Reported in the community forum:
https://forum.proxmox.com/threads/117362/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/node/Summary.js | 1 +
www/manager6/panel/GuestSummary.js | 1 +
2 files changed, 2 insertions(+)
diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js
index 8680fa5f..320f2247 100644
--- a/www/manager6/node/Summary.js
+++ b/www/manager6/node/Summary.js
@@ -162,6 +162,7 @@ Ext.define('PVE.node.Summary', {
title: gettext('CPU usage'),
fields: ['cpu', 'iowait'],
fieldTitles: [gettext('CPU usage'), gettext('IO delay')],
+ unit: 'percent',
store: rrdstore,
},
{
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 6532c3e9..1565db3f 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -75,6 +75,7 @@ Ext.define('PVE.guest.Summary', {
pveSelNode: me.pveSelNode,
fields: ['cpu'],
fieldTitles: [gettext('CPU usage')],
+ unit: 'percent',
store: rrdstore,
},
{
--
2.30.2
next reply other threads:[~2022-11-04 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:42 Fiona Ebner [this message]
2022-11-04 10:44 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104074255.8172-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox