From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 2/2] gui: move rate limit field to advanced section
Date: Thu, 3 Nov 2022 16:38:09 +0100 [thread overview]
Message-ID: <20221103153810.690086-2-d.tschlatscher@proxmox.com> (raw)
In-Reply-To: <20221103153810.690086-1-d.tschlatscher@proxmox.com>
The new MTU field and the rate limit field are now in the advanced
section of the NetworkInputPanel to parallel the layout of the
NetworkEdit for VMs.
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
Changes from v1
* This patch now only moves the rate limit text field
www/manager6/lxc/Network.js | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/www/manager6/lxc/Network.js b/www/manager6/lxc/Network.js
index c6c40934..85033bd8 100644
--- a/www/manager6/lxc/Network.js
+++ b/www/manager6/lxc/Network.js
@@ -122,16 +122,6 @@ Ext.define('PVE.lxc.NetworkInputPanel', {
name: 'tag',
value: cdata.tag,
},
- {
- xtype: 'numberfield',
- name: 'rate',
- fieldLabel: gettext('Rate limit') + ' (MB/s)',
- minValue: 0,
- maxValue: 10*1024,
- value: cdata.rate,
- emptyText: 'unlimited',
- allowBlank: true,
- },
{
xtype: 'proxmoxcheckbox',
fieldLabel: gettext('Firewall'),
@@ -294,6 +284,19 @@ Ext.define('PVE.lxc.NetworkInputPanel', {
},
];
+ me.advancedColumn2 = [
+ {
+ xtype: 'numberfield',
+ name: 'rate',
+ fieldLabel: gettext('Rate limit') + ' (MB/s)',
+ minValue: 0,
+ maxValue: 10*1024,
+ value: cdata.rate,
+ emptyText: 'unlimited',
+ allowBlank: true,
+ },
+ ];
+
me.callParent();
},
});
--
2.30.2
next prev parent reply other threads:[~2022-11-03 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 15:38 [pve-devel] [PATCH manager v2 1/2] fix #3719: gui: expose LXC MTU option in web UI Daniel Tschlatscher
2022-11-03 15:38 ` Daniel Tschlatscher [this message]
2022-11-03 15:38 ` [pve-devel] [PATCH container v2] better parsing for lxc networking mtu setting Daniel Tschlatscher
2022-11-11 11:14 ` [pve-devel] [PATCH manager v2 1/2] fix #3719: gui: expose LXC MTU option in web UI Stefan Hanreich
2022-11-16 19:11 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-17 12:52 ` Wolfgang Bumiller
2022-11-17 13:13 ` DERUMIER, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103153810.690086-2-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox