From: Stefan Sterz <s.sterz@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v4 2/2] ui: only allow rbd pools to be added as rbd storage
Date: Tue, 25 Oct 2022 10:10:46 +0200 [thread overview]
Message-ID: <20221025081046.93094-2-s.sterz@proxmox.com> (raw)
In-Reply-To: <20221025081046.93094-1-s.sterz@proxmox.com>
previously the ui would allow adding all pools (even the default
ceph-mon pools) as storage. this could lead to issues when users did
use these pools as storage (e.g.: vms missing their disks after a
migration). hence, restrict the pool selector to rbd pools.
fails gracefully by reverting to the previous behavior if a pool has
no application assigned to it.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
v3: changed the name of the filter function based on alwin antreich's
suggestion.
v4: renamed the filter function again a, adapted it to be more concise
and make it work with the slightly adapted api response.
www/manager6/form/CephPoolSelector.js | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/CephPoolSelector.js b/www/manager6/form/CephPoolSelector.js
index 5b96398d..e8197077 100644
--- a/www/manager6/form/CephPoolSelector.js
+++ b/www/manager6/form/CephPoolSelector.js
@@ -15,9 +15,15 @@ Ext.define('PVE.form.CephPoolSelector', {
throw "no nodename given";
}
+ let onlyRBDPools = ({ data }) =>
+ !data?.application_metadata || !!data?.application_metadata?.rbd;
+
var store = Ext.create('Ext.data.Store', {
fields: ['name'],
sorters: 'name',
+ filters: [
+ onlyRBDPools,
+ ],
proxy: {
type: 'proxmox',
url: '/api2/json/nodes/' + me.nodename + '/ceph/pools',
@@ -32,8 +38,10 @@ Ext.define('PVE.form.CephPoolSelector', {
store.load({
callback: function(rec, op, success) {
- if (success && rec.length > 0) {
- me.select(rec[0]);
+ let filteredRec = rec.filter(onlyRBDPools);
+
+ if (success && filteredRec.length > 0) {
+ me.select(filteredRec[0]);
}
},
});
--
2.30.2
next prev parent reply other threads:[~2022-10-25 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 8:10 [pve-devel] [PATCH manager v4 1/2] api: ceph: add applications of each pool to the lspools endpoint Stefan Sterz
2022-10-25 8:10 ` Stefan Sterz [this message]
2022-10-25 8:36 ` Aaron Lauterer
2022-11-16 19:25 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025081046.93094-2-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox