public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH qemu-server v4 0/2] qmeventd: improve shutdown behaviour
Date: Fri, 23 Sep 2022 12:20:33 +0200	[thread overview]
Message-ID: <20220923102033.hrhk6di7thyus6qe@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20220923095115.1974215-1-d.csapak@proxmox.com>

applied both patches, thanks

On Fri, Sep 23, 2022 at 11:51:13AM +0200, Dominik Csapak wrote:
> includes the following improvements:
> * increases 'force cleanup' timeout to 60s (from 5)
> * saves individual timeout for each vm
> * don't force cleanup for vms where normal cleanup worked
> * sending QMP quit instead of SIGTERM (less log noise)
> 
> changes from v3:
> * merge CleanupData into Client (pidfd,timeout) and use that for the
>    forced_cleanup list
> * close pidfd also in cleanup_client (and remove itself from the
>    forced_cleanup list)
> * guard the sigkill with a check for timeout != 0
> * with those changes patch 2/3 is not necessary anymore
> 
> changes from v2:
> * change from cast of the function to cast of the parameters
> * don't copy the variable on the stack in 'sigkill'
> 
> changes from v1:
> * remove 'alarm' calls altogether and use epoll_waits' timeout mechanic
>    instead
> * call 'time()' only once and give it as user data to the function
> * change the function singatures and cast on callsite with '(GFunc)'
>    for the g_slist_foreach calls
> * change to <s> for the usage output for timeouts
> 
> Dominik Csapak (2):
>   qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
>   qmeventd: send QMP 'quit' command instead of SIGTERM
> 
>  qmeventd/qmeventd.c | 112 ++++++++++++++++++++++++--------------------
>  qmeventd/qmeventd.h |   8 ++--
>  2 files changed, 65 insertions(+), 55 deletions(-)
> 
> -- 
> 2.30.2




      parent reply	other threads:[~2022-09-23 10:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  9:51 [pve-devel] " Dominik Csapak
2022-09-23  9:51 ` [pve-devel] [PATCH qemu-server v4 1/2] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
2022-09-23  9:51 ` [pve-devel] [PATCH qemu-server v4 2/2] qmeventd: send QMP 'quit' command instead of SIGTERM Dominik Csapak
2022-09-23 10:20 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923102033.hrhk6di7thyus6qe@wobu-vie.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal