public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server/pve-container/pve-docs 0/1] Add pre/post-clone hooks
Date: Fri, 23 Sep 2022 11:55:26 +0200	[thread overview]
Message-ID: <20220923095529.2089346-1-s.hanreich@proxmox.com> (raw)

This patch adds pre/post-clone hooks when the when the user clones a CT/VM
from the Web UI / CLI. I have tested this with both VMs/CTs via Web UI and CLI.
Are there any other places where the hook should get triggered that I missed?

Clone is a bit special since it can either target the same node or a different
node. In the second case, we could also add additional events that fire on the
respective target machine (pre/post-clone-target). In this case the other events
should also be called (pre/post-clone-source) I think. Not sure if there is a
use case for this though. For now we only run the hooks on the source machine, I
think this should suffice. What do you think?


pve-container:

Stefan Hanreich (1):
  Add CT hooks for pre/post-clone

 src/PVE/API2/LXC.pm | 4 ++++
 1 file changed, 4 insertions(+)


pve-docs:

Stefan Hanreich (1):
  add pre/post-clone events to example hookscript

 examples/guest-example-hookscript.pl | 12 ++++++++++++
 1 file changed, 12 insertions(+)


qemu-server:

Stefan Hanreich (1):
  Add VM hooks for pre/post-clone

 PVE/API2/Qemu.pm | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.30.2




             reply	other threads:[~2022-09-23  9:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  9:55 Stefan Hanreich [this message]
2022-09-23  9:55 ` [pve-devel] [PATCH pve-container 1/1] Add CT hooks for pre/post-clone Stefan Hanreich
2022-09-23  9:55 ` [pve-devel] [PATCH pve-docs 1/1] add pre/post-clone events to example hookscript Stefan Hanreich
2022-09-23 10:01   ` Stefan Hanreich
2022-09-23  9:55 ` [pve-devel] [PATCH qemu-server 1/1] Add VM hooks for pre/post-clone Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923095529.2089346-1-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal