public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-container 1/1] Add CT hooks for pre/post-migrate on target/source
Date: Thu, 22 Sep 2022 16:13:19 +0200	[thread overview]
Message-ID: <20220922141321.1510795-3-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20220922141321.1510795-1-s.hanreich@proxmox.com>

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 src/PVE/CLI/pct.pm     | 51 ++++++++++++++++++++++++++++++++++++++++++
 src/PVE/LXC/Migrate.pm | 23 +++++++++++++++++++
 2 files changed, 74 insertions(+)

diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 23793ee..e80586d 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -803,6 +803,54 @@ __PACKAGE__->register_method ({
 	return undef;
     }});
 
+__PACKAGE__->register_method ({
+    name => 'pre_migrate',
+    path => 'pre_migrate',
+    method => 'POST',
+    description => "Run pre-migrate hook for VM <vmid> - do not use manually.",
+    parameters => {
+	additionalProperties => 0,
+	properties => {
+	    vmid => get_standard_option('pve-vmid', { completion => \&PVE::QemuServer::complete_vmid }),
+	    'source-node' => get_standard_option('pve-node'),
+	},
+    },
+    returns => { type => 'null'},
+    code => sub {
+	my ($param) = @_;
+
+	my $vmid = $param->{vmid};
+	my $source_node = $param->{'source-node'};
+	my $conf = PVE::LXC::Config->load_config($vmid, $source_node);
+
+	PVE::GuestHelpers::exec_hookscript($conf, $vmid, "pre-migrate-target", 1);
+
+	return;
+    }});
+
+__PACKAGE__->register_method ({
+    name => 'post_migrate',
+    path => 'post_migrate',
+    method => 'POST',
+    description => "Run post-migrate hook for VM <vmid> - do not use manually.",
+    parameters => {
+	additionalProperties => 0,
+	properties => {
+	    vmid => get_standard_option('pve-vmid', { completion => \&PVE::QemuServer::complete_vmid }),
+	},
+    },
+    returns => { type => 'null'},
+    code => sub {
+	my ($param) = @_;
+
+	my $vmid = $param->{vmid};
+	my $conf = PVE::LXC::Config->load_config($vmid);
+
+	PVE::GuestHelpers::exec_hookscript($conf, $vmid, "post-migrate-target");
+
+	return;
+    }});
+
 our $cmddef = {
     list=> [ 'PVE::API2::LXC', 'vmlist', [], { node => $nodename }, sub {
 	my $res = shift;
@@ -874,6 +922,9 @@ our $cmddef = {
     rescan  => [ __PACKAGE__, 'rescan', []],
     cpusets => [ __PACKAGE__, 'cpusets', []],
     fstrim => [ __PACKAGE__, 'fstrim', ['vmid']],
+
+    'pre-migrate' => [ __PACKAGE__, 'pre_migrate', ['vmid', 'source-node']],
+    'post-migrate' => [ __PACKAGE__, 'post_migrate', ['vmid']],
 };
 
 1;
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 2ef1cce..4089c2c 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -416,4 +416,27 @@ sub final_cleanup {
 
 }
 
+sub pre_migration_hooks {
+    my ($self, $vmid) = @_;
+
+    PVE::GuestHelpers::exec_hookscript($self->{vmconf}, $vmid, 'pre-migrate-source', 1);
+
+    my $node = PVE::INotify::nodename();
+    my $cmd = [ @{$self->{rem_ssh}}, "pct", "pre-migrate", $vmid, $node ];
+
+    eval { $self->cmd($cmd); };
+    die "$@\n" if $@;
+}
+
+sub post_migration_hooks {
+    my ($self, $vmid) = @_;
+
+    PVE::GuestHelpers::exec_hookscript($self->{vmconf}, $vmid, 'post-migrate-source');
+
+    my $cmd = [ @{$self->{rem_ssh}}, "pct", "post-migrate", $vmid ];
+
+    eval { $self->cmd($cmd); };
+    die "$@\n" if $@;
+}
+
 1;
-- 
2.30.2




  parent reply	other threads:[~2022-09-22 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 14:13 [pve-devel] [PATCH pve-container/qemu-server/pve-guest-common/pve-docs 0/1] Add pre/post-migrate hooks Stefan Hanreich
2022-09-22 14:13 ` [pve-devel] [PATCH pve-guest-common 1/1] Add abstract methods for " Stefan Hanreich
2022-09-26 15:27   ` Thomas Lamprecht
2022-09-27  7:40     ` Stefan Hanreich
2022-09-27  8:05       ` Thomas Lamprecht
2022-09-22 14:13 ` Stefan Hanreich [this message]
2022-09-22 14:13 ` [pve-devel] [PATCH pve-docs 1/1] Add pre/post-migrate events for target and source to example hookscript Stefan Hanreich
2022-09-22 14:13 ` [pve-devel] [PATCH qemu-server 1/1] Add VM hooks for pre/post-migrate on target/source Stefan Hanreich
2022-09-26 15:38   ` Thomas Lamprecht
2022-09-27  7:40     ` Stefan Hanreich
2022-09-26 15:51 ` [pve-devel] [PATCH pve-container/qemu-server/pve-guest-common/pve-docs 0/1] Add pre/post-migrate hooks Thomas Lamprecht
2022-09-27  7:40   ` Stefan Hanreich
2022-09-27  7:47     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922141321.1510795-3-s.hanreich@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal